Skip to content
This repository has been archived by the owner on Jul 24, 2018. It is now read-only.

Session is not closed if no changes are done #15

Closed
kossebau opened this issue Sep 5, 2013 · 1 comment
Closed

Session is not closed if no changes are done #15

kossebau opened this issue Sep 5, 2013 · 1 comment

Comments

@kossebau
Copy link
Contributor

kossebau commented Sep 5, 2013

Sessions should be closed if the last member leaves. This does not happen currently.

Drawback is that this also means that the whole stack of operations created is kept around as well as the copy of the original document, so using storage in db and filesystem.
Additionally the startup of the session is taking longer and longer by the time, because all ops ever created have to be replayed, due to the current design.

@ghost ghost assigned VicDeo Sep 6, 2013
VicDeo added a commit that referenced this issue Sep 11, 2013
@VicDeo
Copy link
Contributor

VicDeo commented Sep 20, 2013

Closing fixed except one particular case:
Session cleanup happens only after successful save currently.
When no changes are done to document, the session is not saved (no 'save' request from editor).

We need a separate Ajax request on editor shutdown in case there are no data to save. Or leave it as is - it will store the last cursor position (to go on reading from this place next time)

Updated title accordingly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants