-
Notifications
You must be signed in to change notification settings - Fork 55
Default avatar image is not the official ownCloud default avatar image #22
Comments
Please review the profile picture pull request which will give us proper avatars: owncloud/core#4506 Maybe @Kondou-ger or @kabum can help with implementing that in Documents? :) |
@jancborchardt |
@Kondou-ger I'm tracking the discussions in your PR and don't want to change anything until it is finally merged 🌵 |
Then you won't get any defaultavatars though, as defaultavatars are pure JS … |
"defaultavatars are pure JS" means what exactly? Is that one-time-run JS which creates some image, or is that some html element which is drawn/updated by JS all the time? how would that pure JS be used, what does it do? |
@kossebau yes, it’s just a square div with a generated color and the first letter of the user inside it, in white. It’s used in the Music app as album art placeholder and for every user image placeholder. Performance and load-wise probably a much better solution than having those placeholders as images – especially because they are only needed in the web interface for now. |
@kossebau this is done as a jQuery plugin called on a specific node(s) that takes username and size as parameters: $('#header').avatar(OC.currentUser, 32); |
meh, that conflicts with the concepts implemented currently in webodf, where there is just metadata about users (or rather members of the editing session) delivered from the backend abstraction MemberList :( and "rendering" is done in custom ways, using that metadata, so not some html elements. |
@kossebau I’d say use names and colors only for now, without avatars. No member list at all would also be strange. |
@kossebau @jancborchardt As a temporary stub I can pass a plain color background as an avatar. |
Ok, the avatars and placeholder stuff is now in core, can we have that in Documents? cc @kabum @Kondou-ger |
@jancborchardt we have it. Currently WebODF can use link to avatar only (or data-uri). |
If there is no avatar defined by the user then the smilie should not be used. There should be no image at all there in that case, only the name and color. |
ok, fixed #51 and this one by patching upstream code |
thx |
Seems there is no official ownCloud default avatar ATM. So Documents is using its own default avatar image for now, until there is an official ownCloud one.
Avatar image is is a smiley from tango icon set.
The text was updated successfully, but these errors were encountered: