Skip to content
This repository has been archived by the owner on Nov 2, 2018. It is now read-only.

use url of contacts app for contact pictures #58

Merged
merged 1 commit into from
Aug 12, 2015
Merged

use url of contacts app for contact pictures #58

merged 1 commit into from
Aug 12, 2015

Conversation

v1r0x
Copy link
Contributor

@v1r0x v1r0x commented Aug 11, 2015

(temporary?) fix for #57

@Henni
Copy link
Contributor

Henni commented Aug 11, 2015

This makes the maps app depend on the contacts app. This is probably not what we want.

@v1r0x
Copy link
Contributor Author

v1r0x commented Aug 11, 2015

This is not a new dependency

@jancborchardt
Copy link
Contributor

In any case it should be totally optional. If the Contacts app is not installed, simply do not show the entry in the sidebar and deactivate the functionality.

This is something for a separate PR though it seems?

@Henni
Copy link
Contributor

Henni commented Aug 11, 2015

Yeah right. The difference between Maps & Contacts and Tasks & Calendar is that in this case the dependency isn't mandatory.

@jancborchardt
Copy link
Contributor

Wow … seeing your contacts on the map with images is just pretty awesome! :) Works quite well! 👍

Regarding the dependency, I opened #59

@jancborchardt
Copy link
Contributor

@Henni @brantje what do you think?

@Henni
Copy link
Contributor

Henni commented Aug 11, 2015

Looks great!
I had the issue that the sprite had blue borders at the right and bottom. But that's probably because my default browser zoom level is 125% and thus it's a browser issue.
So 👍 from me

jancborchardt added a commit that referenced this pull request Aug 12, 2015
use url of contacts app for contact pictures
@jancborchardt jancborchardt merged commit 61354cc into owncloud-archive:master Aug 12, 2015
@jancborchardt
Copy link
Contributor

Great stuff @v1r0x, you're awesome! :)

Are you on IRC in our #owncloud-dev channel yet? (Freenode)

@v1r0x
Copy link
Contributor Author

v1r0x commented Aug 12, 2015

Thanks :)
Now I am

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants