made app compliant

[v1r0x]

fixes #75

[v1r0x]

@Henni @brantje @DJaeger @jancborchardt can we merge this?

[Henni]

I'll take a look.
It isn't completely trivial to review this, as these changes could break features in unexpected ways.

[brantje]

Code looks good 👍

[Henni]

While we are on it, let's remove all the deprecated function calls:

[...]

\OC::$server->getNavigationManager()->add(array(
    // the string under which your app will be referenced in owncloud
    'id' => 'maps',

    // sorting weight for the navigation. The higher the number, the higher
    // will it be listed in the navigation
    'order' => 10,

    // the route that will be shown on startup
    'href' => \OC::$server->getURLGenerator()->linkToRoute('maps.page.index'),

    // the icon that will be shown in the navigation
    // this file needs to exist in img/
    'icon' => \OC::$server->getURLGenerator()->imagePath('maps', 'maps.svg'),

    // the title of your application. This will be used in the
    // navigation or on the settings page of your app
    'name' => \OC::$server->getL10N('maps')->t('Maps')
));

[Henni]

Looks good besides my comment above. 👍

[v1r0x]

Should we merge this and create a new PR or add this to this PR?

[Henni]

If you are able to fix it now, do it in this PR. Otherwise we'll create another PR.

[jancborchardt]

@v1r0x can you fix the problem noted by @Henni and then rebase? Cause this needs a rebase anyway before we can merge. :)

[v1r0x]

Looks like I messed up the rebase...Any idea how to revert it?

[v1r0x]

Thanks to @PVince81 "I" fixed it ;)

Please review

[jancborchardt]

@Henni everything addressed you had in mind? :)

[jancborchardt]

Btw @v1r0x you are in the ownCloud organization, so it would be much easier if you work on branches in this repo instead of having a personal fork. :) That way all other ownCloud org folks (such as @Henni and me) can collaborate.

[Henni]

what @jancborchardt said...

Otherwise this PR looks good 👍

[v1r0x]

Will do it next time :)
Ok, I'll merge it then?

[Henni]

Feel free to do so :)