-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
@Henni @brantje @DJaeger @jancborchardt can we merge this? |
I'll take a look. |
Code looks good 👍 |
@@ -29,5 +30,5 @@ | |||
|
|||
// the title of your application. This will be used in the | |||
// navigation or on the settings page of your app | |||
'name' => \OC_L10N::get('maps')->t('Maps') | |||
'name' => $l->t('Maps') | |||
)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are on it, let's remove all the deprecated function calls:
[...]
\OC::$server->getNavigationManager()->add(array(
// the string under which your app will be referenced in owncloud
'id' => 'maps',
// sorting weight for the navigation. The higher the number, the higher
// will it be listed in the navigation
'order' => 10,
// the route that will be shown on startup
'href' => \OC::$server->getURLGenerator()->linkToRoute('maps.page.index'),
// the icon that will be shown in the navigation
// this file needs to exist in img/
'icon' => \OC::$server->getURLGenerator()->imagePath('maps', 'maps.svg'),
// the title of your application. This will be used in the
// navigation or on the settings page of your app
'name' => \OC::$server->getL10N('maps')->t('Maps')
));
Looks good besides my comment above. 👍 |
Should we merge this and create a new PR or add this to this PR? |
If you are able to fix it now, do it in this PR. Otherwise we'll create another PR. |
Looks like I messed up the rebase...Any idea how to revert it? |
Thanks to @PVince81 "I" fixed it ;) Please review |
@Henni everything addressed you had in mind? :) |
what @jancborchardt said... Otherwise this PR looks good 👍 |
Will do it next time :) |
Feel free to do so :) |
fixes #75