Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix default objectstore class and remove autocreate #216

Merged
merged 1 commit into from Jul 12, 2022

Conversation

xoxys
Copy link
Contributor

@xoxys xoxys commented Jul 12, 2022

  • replace objectstore class OCA\\ObjectStore\\S3 by OCA\Files_Primary_S3\S3Storage
  • remove unsupported bucket autocreate option

@phil-davis
Copy link
Contributor

@xoxys can you write something about why this change is needed?

@xoxys
Copy link
Contributor Author

xoxys commented Jul 12, 2022

What information is missing?

The old objectstore class was deprecated a long time ago and was not working anymore. The current one is following our docs https://doc.owncloud.com/server/latest/admin_manual/configuration/files/external_storage/s3_compatible_object_storage_as_primary.html#amazon-s3

The autocreate option does not exist anymore (and for this reason does not work). After internal discussions, this was never intended to work, so lets remove it.

@phil-davis
Copy link
Contributor

"The old objectstore class was deprecated a long time ago and was not working anymore"

"The autocreate option does not exist anymore"

That's good to know - answers my "why" thoughts, thanks.

@xoxys
Copy link
Contributor Author

xoxys commented Jul 12, 2022

Sorry it that was unclear, I thought the information from the pr message were enough :) Thanks for your review

@xoxys xoxys merged commit 167efdb into master Jul 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-objectstore branch July 12, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants