Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump phpstan version to 1.9 #1159

Merged
merged 1 commit into from Dec 2, 2022
Merged

Bump phpstan version to 1.9 #1159

merged 1 commit into from Dec 2, 2022

Conversation

amrita-shrestha
Copy link
Contributor

Description

  • use the latest phpstan, which is 1.9.* series

Related issue

@amrita-shrestha amrita-shrestha self-assigned this Dec 2, 2022
@amrita-shrestha amrita-shrestha marked this pull request as ready for review December 2, 2022 08:55
@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

"phpstan/phpstan": "^1.8"
"phpstan/phpstan": "^1.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: ^1.8 means use any 1.* version from 1.8 onward. So in CI the latest 1.9.2 is already running:
https://drone.owncloud.com/owncloud/activity/3090/3/4

But it does not hurt to update here in composer.json so that we know that at least 1.9 is really being used.

@amrita-shrestha amrita-shrestha merged commit dadf4ad into master Dec 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the bumpPhpStanVersion branch December 2, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants