Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

remove okHttpClient singleton #357

Closed
7 of 8 tasks
theScrabi opened this issue Nov 12, 2020 · 0 comments · Fixed by #364
Closed
7 of 8 tasks

remove okHttpClient singleton #357

theScrabi opened this issue Nov 12, 2020 · 0 comments · Fixed by #364
Assignees
@theScrabi
Labels
Estimation - 3 (M) p3-medium Normal priority

Comments

@theScrabi
Copy link
Contributor

theScrabi commented Nov 12, 2020 •
edited
Loading

Remove the okHttpClient signleton from HttpCleint. Use propper injection which we can do from the OwnCloudClientFactory.

Tasks

  • Make okHttpClient nonsingleton
  • move library remoteoperations to nonsingleton
  • move app remoteoperations to nonsingleton
  • implement injection in library
    • research
  • Add/fix Unit tests in library
  • Add/fix Unit tests in app
  • Test if application runs stable

Implementation

App: owncloud/android#3047
Library: #364
@michaelstingl michaelstingl added the p2-high Escalation, on top of current planning, release blocker label Nov 16, 2020
@jesmrec jesmrec added p3-medium Normal priority and removed p2-high Escalation, on top of current planning, release blocker labels Nov 23, 2020
@theScrabi theScrabi linked a pull request Jan 4, 2021 that will close this issue
remove okhttp singleton #364
Merged
This was referenced Jan 4, 2021
Merged
Merged
@jesmrec jesmrec added p2-high Escalation, on top of current planning, release blocker and removed p3-medium Normal priority labels Jan 22, 2021
@jesmrec jesmrec removed the Sprint label Feb 12, 2021
@theScrabi theScrabi mentioned this issue Mar 10, 2021
Closed
@jesmrec jesmrec added Sprint p3-medium Normal priority and removed p2-high Escalation, on top of current planning, release blocker labels Mar 12, 2021
@jesmrec jesmrec added Sprint and removed Sprint labels Mar 26, 2021
@jesmrec jesmrec added the Sprint label Apr 16, 2021
@theScrabi theScrabi removed a link to a pull request Apr 30, 2021
remove okhttp singleton #364
Merged
@theScrabi theScrabi linked a pull request Apr 30, 2021 that will close this issue
remove okhttp singleton #364
Merged
@jesmrec jesmrec removed the Sprint label May 7, 2021
@jesmrec jesmrec added the Sprint label Jul 30, 2021
@jesmrec jesmrec removed the Sprint label Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theScrabi theScrabi

Labels
Estimation - 3 (M) p3-medium Normal priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove okhttp singleton owncloud/android-library
3 participants
@michaelstingl @theScrabi @jesmrec