Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

remove okhttp singleton #364

Merged
merged 9 commits into from
Apr 27, 2022
Merged

remove okhttp singleton #364

merged 9 commits into from
Apr 27, 2022

Conversation

theScrabi
Copy link
Contributor

@theScrabi theScrabi commented Jan 4, 2021 •
edited
Loading

issue: #357
depends on: owncloud/android#3047

This was referenced Jan 4, 2021
Merged
Closed
Closed
@theScrabi theScrabi linked an issue Jan 4, 2021 that may be closed by this pull request
remove okHttpClient singleton #357
Closed
8 tasks
@theScrabi theScrabi marked this pull request as ready for review January 18, 2021 10:15
@theScrabi theScrabi force-pushed the fix/okhttp_singleton branch 2 times, most recently from 812361a to ea12297 Compare February 23, 2021 11:32
abelgardep
abelgardep suggested changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions here @theScrabi

owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/OwnCloudClient.java Show resolved Hide resolved
owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/http/HttpClient.java Outdated Show resolved Hide resolved
owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/http/HttpClient.java Outdated Show resolved Hide resolved
owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/http/HttpClient.java Outdated Show resolved Hide resolved
@theScrabi theScrabi removed a link to an issue Apr 30, 2021
remove okHttpClient singleton #357
Closed
8 tasks
@theScrabi theScrabi linked an issue Apr 30, 2021 that may be closed by this pull request
remove okHttpClient singleton #357
Closed
8 tasks
abelgardep
abelgardep suggested changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions here @theScrabi

.gitignore Outdated Show resolved Hide resolved
owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/OwnCloudClientFactory.java Outdated Show resolved Hide resolved
@jesmrec
Copy link
Collaborator

jesmrec commented Jul 30, 2021

test: regression. switch accounts.

@theScrabi theScrabi force-pushed the fix/okhttp_singleton branch 2 times, most recently from ae9dcc8 to 3b07775 Compare August 5, 2021 07:37
@theScrabi theScrabi force-pushed the fix/okhttp_singleton branch 2 times, most recently from 3b07775 to d19bfec Compare August 18, 2021 15:13
abelgardep
abelgardep approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @theScrabi

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 24, 2021

QA

app commit: 70d77a35

E2E tests (without login tests). Passed ✅

serenity_singleton.zip

E2E tests (login tests) Passed ✅

serenity_login.zip

Transfers' checks:

  • Upload single file
  • Upload single (big) file
  • Upload a bunch of files (<50)
  • Download file
  • Download big file
  • Transfer error: connectivity lost -> correct error. Recovering connection, transfers are retried
  • Transfer error: target removed -> correct error
  • Transfer error: lack of permissions -> known error [BUG] UI glitch view uploading content to a non-allowed folder android#2653
  • Transfer error: maintenance mode -> correct error
  • Transfer error: app killed -> correct error
  • Transfer error: account deleted -> upload removed (no matter if pending, ongoing or finished)

Switching accounts

  • Same server: switching accounts, browsing, performing operations through them ✅

  • Different server: switching accounts, browsing, performing operations through them ✅

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 24, 2021

Approved on my side

@jesmrec jesmrec mentioned this pull request Oct 11, 2021
Closed
1 task
@jesmrec
Copy link
Collaborator

jesmrec commented Oct 21, 2021

To resumen when https://github.com/owncloud/enterprise/issues/4201 is done and merged

@theScrabi theScrabi force-pushed the fix/okhttp_singleton branch 2 times, most recently from 27ecf79 to 9db0a81 Compare March 24, 2022 16:46
@theScrabi theScrabi force-pushed the fix/okhttp_singleton branch 2 times, most recently from 5984a39 to 9ab11f8 Compare April 13, 2022 13:23
abelgardep
abelgardep suggested changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theScrabi Some suggestions here

owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/http/HttpClient.java Outdated Show resolved Hide resolved
owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/http/HttpClient.java Outdated Show resolved Hide resolved
owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/http/methods/HttpBaseMethod.kt Outdated Show resolved Hide resolved
owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/http/methods/HttpBaseMethod.kt Show resolved Hide resolved
owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/http/methods/HttpBaseMethod.kt Outdated Show resolved Hide resolved
.../src/main/java/com/owncloud/android/lib/resources/files/CheckPathExistenceRemoteOperation.kt Outdated Show resolved Hide resolved
sample_client/src/main/java/com/owncloud/android/lib/sampleclient/MainActivity.java Outdated Show resolved Hide resolved
sample_client/src/main/java/com/owncloud/android/lib/sampleclient/MainActivity.java Outdated Show resolved Hide resolved
owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/OwnCloudClientFactory.java Outdated Show resolved Hide resolved
abelgardep
abelgardep approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.gitignore Outdated Show resolved Hide resolved
@jesmrec jesmrec mentioned this pull request Apr 27, 2022
Closed
4 tasks
@abelgardep abelgardep merged commit 4de236b into master Apr 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/okhttp_singleton branch April 27, 2022 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hannesa2 hannesa2 hannesa2 left review comments

@abelgardep abelgardep abelgardep approved these changes

Assignees

@theScrabi theScrabi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove okHttpClient singleton
4 participants
@theScrabi @jesmrec @hannesa2 @abelgardep