Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use one notification #1194

Closed
jancborchardt opened this issue Oct 11, 2015 · 3 comments
Closed

Only use one notification #1194

jancborchardt opened this issue Oct 11, 2015 · 3 comments

Comments

@jancborchardt
Copy link
Member

Currently when downloading multiple files, you often end up with 2 notifications: one for the download in progress, and one for the »success« notification of the previous download:
screenshot_2015-10-11-14-47-09

When there is another download coming right after, it is unnecessary to show the success notification. An error notification when something went wrong is enough, and a summary success notification at the end (which of course vanishes like the one currently does.)

cc @davivel @masensio @AndyScherzinger @tobiasKaminsky @stoyicker

@AndyScherzinger
Copy link
Member

I think @tobiasKaminsky already took care of this in another PR :)

@tobiasKaminsky
Copy link
Contributor

No, I think you mixed it with the "wait a moment".
In #1168 I have removed the "wait a moment" dialog for removing files as I would otherwise have to keep track of the deleted files to remove the dialog with the last file.

@davivel
Copy link
Contributor

davivel commented Feb 24, 2016

Subsumed by #1468

@davivel davivel closed this as completed Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants