Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a unique X-Request-ID header to allow tracing requests in apache and owncloud logs #2055

Closed
3 tasks done
butonic opened this issue Oct 25, 2017 · 5 comments
Closed
3 tasks done
Assignees
Milestone

Comments

@butonic
Copy link
Member

butonic commented Oct 25, 2017

owncloud/core#28144 has been merged. It will use the value of a X-Request-ID header as the request id in log files to allow linking events on the client to events in the apache and owncloud logs.

  • generate a string to use as unique id.
    • 20-200 chars
    • only [a-zA-Z0-9-+/_=.:] allowed
  • use it in the client log
  • send it as X-Request-ID header on every request
@michaelstingl
Copy link
Contributor

Client log only works if Android app is built with debug option, for example the beta builds in Play Store ad F-Droid (available in ownBrander too).

@jesmrec jesmrec added this to the 2.9.0 milestone Jun 19, 2018
@davigonz davigonz self-assigned this Aug 9, 2018
@davigonz
Copy link
Contributor

davigonz commented Aug 9, 2018

I've just implemented this within the network library replacement branch, commit cd60d63

@michaelstingl
Copy link
Contributor

cool, awesome!

@jesmrec
Copy link
Collaborator

jesmrec commented Oct 5, 2018

i'd use UUID notation (as in new iOS app) for each request (32 hexadecimal digits: 8 + 4 + 4 + 4 + 12). I think it is a bit cleaner than using any character and any length between 20 and 200.

For logs in debug, including the id + method is enough info from my pov to debug-track issues

@michaelstingl
Copy link
Contributor

I think it was UUID v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants