Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable biometrical login by default after setting the passcode #3539

Merged
merged 25 commits into from
Feb 7, 2022

Conversation

fesave
Copy link
Contributor

@fesave fesave commented Feb 1, 2022

Related Issues

App: https://github.com/owncloud/enterprise/issues/4977

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.20/3539-enable_biometrical_after_passcode.md

@fesave fesave self-assigned this Feb 1, 2022
@fesave fesave changed the title Feature/enable biometrical mode Enable biometrical login by default after setting the passcode Feb 1, 2022
@fesave fesave force-pushed the feature/enable_biometrical_mode branch from 17d6de9 to 062be93 Compare February 1, 2022 12:59
@fesave fesave marked this pull request as ready for review February 1, 2022 12:59
@fesave fesave force-pushed the feature/enable_biometrical_mode branch from 5f235b7 to 24c0567 Compare February 1, 2022 17:19
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @fesave! Some comments and changes requested here

@fesave fesave requested a review from JuancaG05 February 3, 2022 12:29
@fesave fesave force-pushed the feature/enable_biometrical_mode branch 2 times, most recently from ed33a68 to 8631c47 Compare February 3, 2022 13:29
@CLAassistant
Copy link

CLAassistant commented Feb 3, 2022

CLA assistant check
All committers have signed the CLA.

@fesave fesave force-pushed the feature/enable_biometrical_mode branch 2 times, most recently from ffa962c to 14cf96e Compare February 4, 2022 07:51
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny things here @fesave

Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @fesave! 👍

@fesave fesave force-pushed the feature/enable_biometrical_mode branch from 995d2b9 to 90af453 Compare February 7, 2022 07:04
@jesmrec jesmrec added this to the 2.20-current milestone Feb 7, 2022
@jesmrec jesmrec merged commit f8de537 into master Feb 7, 2022
@jesmrec jesmrec deleted the feature/enable_biometrical_mode branch February 7, 2022 11:47
@jesmrec jesmrec removed the Sprint label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants