Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Manage password policy in live mode #4269

Closed
15 of 16 tasks
jesmrec opened this issue Dec 18, 2023 · 1 comment · Fixed by #4276
Closed
15 of 16 tasks

[FEATURE REQUEST] Manage password policy in live mode #4269

jesmrec opened this issue Dec 18, 2023 · 1 comment · Fixed by #4276

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Dec 18, 2023

Take a look how the web works when the password policy must be set:

Screen.Recording.2023-12-18.at.17.23.51.mov

this would be cool to be implemented as well. We can take advantage of the capabilities information

 "password_policy": {
                    "max_characters": 72,
                    "min_characters": 8,
                    "min_digits": 1,
                    "min_lowercase_characters": 1,
                    "min_special_characters": 1,
                    "min_uppercase_characters": 1
}

to handle this.

Putting the focus in oCIS, if oC10 is straight forward it will be also ok.

INFO: https://github.com/owncloud/ocis/tree/master/services/frontend#the-password-policy

TASKS

  • Research (if needed)
  • Create branch feature/manage_password_policy_in_live_mode
  • Development tasks
    • Create new columns in the capabilities table in database: password_policy_max_characters, password_policy_min_characters, password_policy_min_digits, password_policy_min_lowercase_characters, password_policy_min_special_characters and password_policy_min_uppercase_characters
    • Add new properties for these new columns in CapabilityResponse and its toRemoteCapability() method
    • Add new properties in RemoteCapability
    • Once we already have them in database, change UI of the password dialog and add each of the messages with the criteria: "At least X characters long", etc
    • Show each criteria message only if value in database of the corresponding criteria is different to null
    • Add listeners for each change in the EditText for the password input: everytime the user writes or deletes a character, we need to update which criteria are fulfilled
    • Enable "Save" button just when all the criteria are fulfilled
    • Improve criteria messages and show them in red when they are not fulfilled, and in green when they are (just like in the web screenshot)
    • Create or adapt the necessary tests
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/shares_password_policy_capabilities into master
@jesmrec jesmrec added this to the 4.3 - Future milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants