Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Password generator for public links #4308

Closed
10 of 11 tasks
TheOneRing opened this issue Feb 6, 2024 · 2 comments · Fixed by #4349
Closed
10 of 11 tasks

[FEATURE REQUEST] Password generator for public links #4308

TheOneRing opened this issue Feb 6, 2024 · 2 comments · Fixed by #4349

Comments

@TheOneRing
Copy link
Member

TheOneRing commented Feb 6, 2024

Is your feature request related to a problem? Please describe.
Along with the password policy, the iOS client implements a password generator.

Describe the solution you'd like
The generator creates passwords that follow the policy and in general should have a higher entropy than a user generated password.
The implementation should be aligned with the iOS implementation.

Additional context
iOS code: https://github.com/owncloud/ios-sdk/blob/develop/ownCloudSDK/Password%20Policy/OCPasswordPolicy%2BGenerator.m#L24

Possible password policies to fulfill are the following (values are server-customizable):

"password_policy": {
                   "max_characters": 72,
                   "min_characters": 8,
                   "min_digits": 1,
                   "min_lowercase_characters": 1,
                   "min_special_characters": 1,
                   "min_uppercase_characters": 1
}

TASKS

  • Research (if needed)
  • Create branch feature/password_generator_public_links
  • Development tasks
    • Create password generator algorithm
    • Add a button to generate password (only for oCIS)
    • Add a button to copy password (only for oCIS)
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/password_generator_public_links into master
@TheOneRing TheOneRing modified the milestones: backlog, 4.3 - Future Feb 6, 2024
@jesmrec
Copy link
Collaborator

jesmrec commented Feb 6, 2024

Needs research to check for available solutions in the Android world

@JuancaG05
Copy link
Collaborator

Needs research to check for available solutions in the Android world

None of the available solutions was suitable (in addition to the fact that none of them is native).
Developing our own solution then 👨🏼‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants