Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Improvements in remove confirmation dialog #4342

Closed
10 tasks done
JuancaG05 opened this issue Mar 19, 2024 · 2 comments · Fixed by #4348
Closed
10 tasks done

[FEATURE REQUEST] Improvements in remove confirmation dialog #4342

JuancaG05 opened this issue Mar 19, 2024 · 2 comments · Fixed by #4348

Comments

@JuancaG05
Copy link
Collaborator

JuancaG05 commented Mar 19, 2024

Is your feature request related to a problem? Please describe.
The remove confirmation dialog is currently pretty simple, and could be improved by showing some valuable information (being aware of not overloading the dialog, that's not the aim).

Describe the solution you'd like
I think it would be nice to apply 2 different improvements:

  1. When removing a file with thumbnail, it would be cool to show the thumbnail in the dialog to know exactly which file we are going to delete (also to avoid misclicks). Currently, we just show the title, which can be non-descriptive sometimes:
  1. When removing several files, it would be nice to show the number of elements selected. Currently, we show a common message for every case. It's true that there's a conflictive case, in which we select a folder: should we consider it as just 1 element or count recursively all the elements contained there? Right now it looks like this:

Describe alternatives you've considered
Proposals are welcome, and more ideas or suggestions as well 🙂.

TASKS

  • Research (if needed)
  • Create branch feature/improvements_remove_dialog
  • Development tasks
    • Add thumbnail in remove dialog, just for files with thumbnails
    • Add number of elements in remove dialog when selecting several files to remove
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/improvements_remove_dialog into master
@jesmrec
Copy link
Collaborator

jesmrec commented Mar 19, 2024

When removing an image, it would be cool to show the thumbnail in the dialog to know exactly which image we are going to delete (also to avoid misclicks). Currently, we just show the title, which can be non-descriptive sometimes:

Should we show everything that contains a thumbnail? for example a txt file, not only an image. If we are ready for this, app will be ready to show any supported thumbnail in the future.

@JuancaG05
Copy link
Collaborator Author

Should we show everything that contains a thumbnail? for example a txt file, not only an image. If we are ready for this, app will be ready to show any supported thumbnail in the future.

Sure! I didn't realise about them. I'll update the main comment, thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants