Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcloudproviders DBus path is no longer unique #10914

Closed
fmoc opened this issue Jun 6, 2023 · 1 comment
Closed

libcloudproviders DBus path is no longer unique #10914

fmoc opened this issue Jun 6, 2023 · 1 comment
Labels
Milestone

Comments

@fmoc
Copy link
Contributor

fmoc commented Jun 6, 2023

#10911 introduced sanitizing for the libcloudproviders DBus path that is deduced from the reverse domain name provided by the theme. As with all sanitizing, this potentially removes the uniqueness property from the value, as more than one input value can generate the same output.

We may want to think about how to make these values unique again, e.g., by using some sort of unique identifier. This value (and maybe the resulting DBus path) would have to be stored inside the theme, though. However, this would allow for checking whether the values are unique at least for the themes we provide and use.

CC @erikjv

@fmoc fmoc added Enhancement p4-low Low priority labels Jun 6, 2023
@fmoc fmoc added this to the Desktop Client 5.0 milestone Jun 6, 2023
@TheOneRing
Copy link
Member

We decided to remove libcloudproviders support.

@TheOneRing TheOneRing closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants