Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual file context menu options should be in submenu #7083

Closed
ckamm opened this issue Mar 13, 2019 · 11 comments
Closed

Virtual file context menu options should be in submenu #7083

ckamm opened this issue Mar 13, 2019 · 11 comments
Labels
Design & UX Enhancement feature:vfs native virtual files and placeholder implementation good first issue Linux p4-low Low priority
Milestone

Comments

@ckamm
Copy link
Contributor

ckamm commented Mar 13, 2019

Follow up from #6815.

Currently the vfs actions appear next to sharing options etc. That's fine while there are few options but will become cluttered as the number of actions increases. A separator or maybe a submenu would be best.

Depends on #6921 and similar work for other shell extensions.

@ckamm ckamm added this to the 2.7.0 milestone Mar 13, 2019
@ckamm ckamm added the feature:vfs native virtual files and placeholder implementation label Mar 13, 2019
@michaelstingl michaelstingl added the p4-low Low priority label Feb 17, 2020
@michaelstingl michaelstingl modified the milestones: 2.7.0, backlog Feb 17, 2020
@michaelstingl
Copy link
Contributor

For Native WinVFS, maybe no longer necessary. (see #7746)

@fmoc
Copy link
Contributor

fmoc commented Apr 14, 2021

@michaelstingl as far as I can see, #7746 suggests to revert on Windows what this issue suggests to introduce on Linux. Which strategy should be followed: submenu or not? We should decide on a single approach and then implement this everywhere to provide a consistent UX on all platforms.

Wrong assumption, see below.

@michaelstingl
Copy link
Contributor

submenu or not?

I think we can't control this in Windows. so others platforms would need to follow…

@TheOneRing
Copy link
Member

I assume this ticket was about changing
image

@fmoc
Copy link
Contributor

fmoc commented Apr 22, 2021

Oh, I see... Well, adding a submenu there likely makes things worse, so I'd rather try to add a separator.

@fmoc
Copy link
Contributor

fmoc commented Apr 22, 2021

It doesn't seem like GNOME's Nautilus extension API provides any functionality to add separators, and an empty entry is even worse. I guess we'll have to add a submenu. However, that's would be quite ugly with the current socket API...

@TheOneRing
Copy link
Member

@tbsbdr afaik sub menus in submenus are considered bad year 2k ux, am I right?

@fmoc
Copy link
Contributor

fmoc commented Apr 22, 2021

Well, either a submenu, or we'll leave it as is for the Nautilus version. I'm looking into the Dolphin implementation next.

@fmoc
Copy link
Contributor

fmoc commented Apr 22, 2021

Adding a separator in Dolphin worked fine. For GNOME, we would have to use a submenu, or leave things as they are.

@tbsbdr
Copy link

tbsbdr commented Apr 27, 2021

@tbsbdr afaik sub menus in submenus are considered bad year 2k ux, am I right?

jep, don't! (unless you have very very good reason..)

@fmoc
Copy link
Contributor

fmoc commented May 6, 2021

I think we can close this issue then? Given we don't want to add a submenu but Nautilus doesn't provide separators, we won't be making changes there. For Dolphin, the PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design & UX Enhancement feature:vfs native virtual files and placeholder implementation good first issue Linux p4-low Low priority
Projects
None yet
Development

No branches or pull requests

5 participants