Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop client locking out Active Directory accounts (New Issue) #7205

Closed
gl1ch opened this issue May 23, 2019 · 8 comments
Closed

Desktop client locking out Active Directory accounts (New Issue) #7205

gl1ch opened this issue May 23, 2019 · 8 comments
Labels

Comments

@gl1ch
Copy link

gl1ch commented May 23, 2019

Expected behaviour

When user changes password in Active Directory the ownCloud client should prompt the user to enter a password after one or two login failures.

Actual behaviour

The ownCloud client repeatedly trys the saved password until the account is locked out. The user then has to know to check the ownCloud client and log out of it (as there is no obvious way to update the password anymore).

Steps to reproduce

  1. Change AD password
  2. Have the owncloud client running

Server configuration

Operating system: Ubuntu

Web server: Apache

Database: MySQL

PHP version:

ownCloud version: 10.0.10

Storage backend (external storage): Local

Client configuration

Client version: 2.5.4 and newer

Operating system: Windows 10

OS language: English / Japanese

Qt version used by client package (Linux only, see also Settings dialog):

Client package (From ownCloud or distro) (Linux only):

Installation path of client:

Logs

Please use Gist (https://gist.github.com/) or a similar code paster for longer
logs.

Template for output < 10 lines

  1. Client logfile: Output of owncloud --logwindow or owncloud --logfile log.txt
    (On Windows using cmd.exe, you might need to first cd into the ownCloud directory)
    (See also http://doc.owncloud.org/desktop/2.2/troubleshooting.html#client-logfile )

  2. Web server error log:

  3. Server logfile: ownCloud log (data/owncloud.log):

@ogoffart
Copy link
Contributor

ogoffart commented Jun 4, 2019

I tested changing my password, and the client only makes two retry to the owncloud server with the old password before asking the user the new password.
The first one is because it thinks the password is correct, and the second one because the auth code does one request to know which authentication we need, and still has the old credentials.
Arguably, the second call is not needed, but still, this should not cause to try too many times.

How many calls does the client do for you?

@gl1ch
Copy link
Author

gl1ch commented Jun 4, 2019 via email

@ogoffart
Copy link
Contributor

ogoffart commented Jun 4, 2019

No, I'm just using the owncloud client with the owncloud server. Looking at the amount of request done from the client to the server.

Maybe there is a problem in the server causing the server not to change the password.
Could be owncloud/core#33853

@gl1ch
Copy link
Author

gl1ch commented Jun 4, 2019 via email

@ogoffart
Copy link
Contributor

ogoffart commented Jun 4, 2019

I do not have a LDAP setup right now to test.
Is OAuth2 enabled or are users using their login/password from the client?

As I said, in my test, the Client does two request with the previous password before showing the dialog.

Is it maybe because the owncloud server does cache the password as well, ad does not report credentials faillure properly to the client? or does many request to the LDAP server for each client request?

@gl1ch
Copy link
Author

gl1ch commented Jun 5, 2019 via email

@gl1ch
Copy link
Author

gl1ch commented Jun 5, 2019 via email

@guruz guruz added the bug label Jun 12, 2019
@TheOneRing
Copy link
Member

Nowadays oauth or open id connect is the way to go, basic auth has a low prio for us and isn't recommended in such an scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants