Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querying the explorer properties of a dehydrated file downloads and discards the whole file #8002

Open
Tracked by #4
SamuAlfageme opened this issue Aug 5, 2020 · 6 comments
Labels
Enhancement feature:vfs native virtual files and placeholder implementation Needs info

Comments

@SamuAlfageme
Copy link
Contributor

Expected behavior

The information from the (sync journal) metadata table or a single PROPFIND would return all the information required to fill the file properties, as it happens with folders.

Actual behavior

The whole file contents are downloaded (GET) and then discarded (i.e. not stored in disk).

Steps to reproduce

  1. Right click on a dehydrated (available when online) large file and choose "Properties".
  2. See the progress bar on the "Status" column filling.

Logs

08-05 15:17:00:897 [ info sync.vfs ]:	FETCH
08-05 15:17:00:897 [ info sync.vfs ]:	fetch data request "C:/Users/Alfageme/ownCloud/" "\\Users\\Alfageme\\ownCloud\\CERN-VIDEO-2020-019-001.mov.gz" "82697677313146880" 0 96301844 0 0
08-05 15:17:00:898 [ debug sync.database.sql ]	[ OCC::SqlQuery::bindValue ]:	SQL bind 1 "82697677313146880"
08-05 15:17:00:898 [ debug sync.database.sql ]	[ OCC::SqlQuery::exec ]:	SQL exec "SELECT path, inode, modtime, type, md5, fileid, remotePerm, filesize,  ignoredChildrenRemote, contentchecksumtype.name || ':' || contentChecksum FROM metadata  LEFT JOIN checksumtype as contentchecksumtype ON metadata.contentChecksumTypeId == contentchecksumtype.id WHERE fileid=?1"
08-05 15:17:00:898 [ info gui.folder.manager ]:	>========== Sync started for folder [ownCloud] of account [cernbox.cern.ch (Samuel Alfageme Sainz (salfagem))] with remote [https://cernbox.cern.ch/cernbox/desktop/remote.php/webdav/home]
08-05 15:17:00:898 [ debug gui.socketapi ]	[ OCC::SocketApi::slotUpdateFolderView ]:	Not sending UPDATE_VIEW for "1" because status() is OCC::SyncResult::SyncRunning
08-05 15:17:00:900 [ info gui.application ]:	Sync state changed for folder  "https://cernbox.cern.ch/cernbox/desktop/remote.php/webdav/home" :  "Sync Running"
[...]
08-05 15:17:00:900 [ debug sync.networkjob.get ]	[ OCC::GETFileJob::start ]:	QObject(0x0) false false
08-05 15:17:00:900 [ info sync.networkjob ]:	OCC::GETFileJob created for "https://cernbox.cern.ch/cernbox/desktop" + "/home/CERN-VIDEO-2020-019-001.mov.gz" "OCC::HydrationContext"

Client configuration

Client version: CERNBox 2.7.0v270beta1 (build 1913)

@SamuAlfageme SamuAlfageme added Enhancement feature:vfs native virtual files and placeholder implementation labels Aug 5, 2020
@TheOneRing
Copy link
Member

What is a large file for you :)

@SamuAlfageme
Copy link
Contributor Author

@TheOneRing e.g. /home/CERN-VIDEO-2020-019-001.mov.gz from the logs above is 96301844 bytes (96MB) and resulted on a OCC::GETFileJob when querying its properties from the explorer.

I have the impression that this behavior could also be a collateral of #7999.

@TheOneRing
Copy link
Member

Could you try it again, this time directly use https://cernbox.cern.ch not https://cernbox.cern.ch/cernbox/desktop/ .
I'm not sure what is behind https://cernbox.cern.ch/cernbox/desktop/ but it uses content types like plain/text and in general does not work.

You should also have seen something like
image

@michaelstingl
Copy link
Contributor

You should also have seen something like

This doesn't happen with the branded CERNBox client. (/home branded as sync root and as quota root). With the unbranded ownCloud client, you need to manually create a new folder sync connection syncing /home

@TheOneRing
Copy link
Member

@TheOneRing
Copy link
Member

@SamuAlfageme can we close this issue or does the problem still exist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement feature:vfs native virtual files and placeholder implementation Needs info
Projects
None yet
Development

No branches or pull requests

3 participants