Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell integration plugins have dependency on client in distro packaging #9034

Open
fmoc opened this issue Sep 16, 2021 · 8 comments
Open

Shell integration plugins have dependency on client in distro packaging #9034

fmoc opened this issue Sep 16, 2021 · 8 comments
Assignees
Milestone

Comments

@fmoc
Copy link
Contributor

fmoc commented Sep 16, 2021

Follow-up from #8967 (comment).

@TheOneRing reports that distro provided Dolphin plugin packages have a superfluous dependency on the client package. It should at most be a recommendation or suggestion.

To add some context: the shell integration plugins hardly ever change, as they pull information like the menu entries they shall generate from the client. A years-old shell integration plugin can work just fine with an up-to-date AppImage for instance.
As we cannot easily ship the shell integration in AppImages (especially the Dolphin plugin is troublesome), we consider recommending users to install the distro packages until there is a solution. It makes no sense to require them to install an old client in such a scenario. And the client is not a strict dependency (the plugin can be installed just fine without the client, it won't do anything useful but it does not cause issues). Therefore, the relation between the two packages should be relaxed.

@fmoc fmoc added the Linux label Sep 16, 2021
@fmoc
Copy link
Contributor Author

fmoc commented Sep 16, 2021

Debian depends on the client package: https://packages.debian.org/buster/dolphin-owncloud
Same goes for Ubuntu: https://packages.ubuntu.com/focal/dolphin-owncloud

I've been looking a bit for similar packages in RPM-based distros, but I can't find such packages for CentOS/Fedora or openSUSE, for instance. I suppose they package the shell integration within the main client package?

@fmoc fmoc changed the title https://github.com/owncloud/client/issues/8967#issuecomment-913488210 Shell integration plugins have dependency on client in distro packaging Sep 17, 2021
@TheOneRing
Copy link
Member

Debian depends on the client package: https://packages.debian.org/buster/dolphin-owncloud
Same goes for Ubuntu: https://packages.ubuntu.com/focal/dolphin-owncloud

I've been looking a bit for similar packages in RPM-based distros, but I can't find such packages for CentOS/Fedora or openSUSE, for instance. I suppose they package the shell integration within the main client package?

@dragotin you can fill in the suse part :D

@github-actions
Copy link

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 18, 2021
@TheOneRing TheOneRing removed the Stale label Oct 18, 2021
@TheOneRing TheOneRing added this to the 2.10.0 milestone Oct 18, 2021
@TheOneRing TheOneRing modified the milestones: 3.0, Backlog Jul 22, 2022
@TheOneRing TheOneRing added the p3-medium Normal priority label Sep 8, 2022
@fmoc fmoc modified the milestones: 3.0, 3.1 Nov 4, 2022
@fmoc
Copy link
Contributor Author

fmoc commented Dec 8, 2022

I asked the Debian maintainers to remove the hard dependency on the client platform on the mailing list.

@fmoc
Copy link
Contributor Author

fmoc commented Dec 16, 2022

@TheOneRing
Copy link
Member

The current script does not install the shell extensions on one of the biggest distros out there.
In my opinion there is no harm in installing the outdated client, as long as we describe why we do it, and that the user should only use the Appimage and not the outdated 2.5 client.

@fmoc
Copy link
Contributor Author

fmoc commented Dec 21, 2022

This doesn't accurately describe the situation. The script does install shell extensions, but it refuses to install the downstream Debian packages. It will, however, install our upstream packages.

I don't really have a preference. I can relate to the argument that it'd be confusing to have more than one ownCloud menu entry around...

@dragotin
Copy link
Contributor

Sorry for being late to the party. This is the source of the openSUSE package, just for reference:
https://build.opensuse.org/package/show/KDE:Extra/owncloud-client

From there it is semi-automatically pulled into the openSUSE Tumbleweed distro and later into the released versions like Leap 15.4.

The current package also has a hard dep from owncloud-client-dolphin to the main client package.

I can package the dolphin plugin completely independent if we have separate sources (a real tarball I mean). If not, it is probably better to leave it with the main package, but just remove the dependency.

@TheOneRing TheOneRing modified the milestones: 3.1, 4.0 Jan 5, 2023
@TheOneRing TheOneRing added p4-low Low priority and removed p3-medium Normal priority labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants