-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shell integration plugins have dependency on client in distro packaging #9034
Comments
Debian depends on the client package: https://packages.debian.org/buster/dolphin-owncloud I've been looking a bit for similar packages in RPM-based distros, but I can't find such packages for CentOS/Fedora or openSUSE, for instance. I suppose they package the shell integration within the main client package? |
@dragotin you can fill in the suse part :D |
This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days. |
I asked the Debian maintainers to remove the hard dependency on the client platform on the mailing list. |
Our installation script skips the known incompatible Debian/Ubuntu packages: https://github.com/owncloud/client-desktop-install-shell-integration/blob/487024717f00275ab99a17e1cba7848069614d0e/install-extensions.sh#L183-L191 |
The current script does not install the shell extensions on one of the biggest distros out there. |
This doesn't accurately describe the situation. The script does install shell extensions, but it refuses to install the downstream Debian packages. It will, however, install our upstream packages. I don't really have a preference. I can relate to the argument that it'd be confusing to have more than one ownCloud menu entry around... |
Sorry for being late to the party. This is the source of the openSUSE package, just for reference: From there it is semi-automatically pulled into the openSUSE Tumbleweed distro and later into the released versions like Leap 15.4. The current package also has a hard dep from owncloud-client-dolphin to the main client package. I can package the dolphin plugin completely independent if we have separate sources (a real tarball I mean). If not, it is probably better to leave it with the main package, but just remove the dependency. |
Follow-up from #8967 (comment).
@TheOneRing reports that distro provided Dolphin plugin packages have a superfluous dependency on the client package. It should at most be a recommendation or suggestion.
To add some context: the shell integration plugins hardly ever change, as they pull information like the menu entries they shall generate from the client. A years-old shell integration plugin can work just fine with an up-to-date AppImage for instance.
As we cannot easily ship the shell integration in AppImages (especially the Dolphin plugin is troublesome), we consider recommending users to install the distro packages until there is a solution. It makes no sense to require them to install an old client in such a scenario. And the client is not a strict dependency (the plugin can be installed just fine without the client, it won't do anything useful but it does not cause issues). Therefore, the relation between the two packages should be relaxed.
The text was updated successfully, but these errors were encountered: