Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] [Win] Remove connection doesn't delete sync db #9057

Closed
gabi18 opened this issue Sep 20, 2021 · 7 comments · Fixed by #9078
Closed

[QA] [Win] Remove connection doesn't delete sync db #9057

gabi18 opened this issue Sep 20, 2021 · 7 comments · Fixed by #9078
Milestone

Comments

@gabi18
Copy link
Contributor

gabi18 commented Sep 20, 2021

Seen on Win 10 20H2, Client 2.9.1daily20210920 (build 5220)

Steps to reproduce

  • remove an existing account (VFS ON or OFF -> same result)
  • add a new account and try to reuse previous sync folder

Result

  • error popup: already used by another account (reason: .sync_journal.db isn't deleted)

remove_account_db

add_account_error

20210920_0958_owncloud.log.0.gz

Expected behaviour

  • reuse should be possible, db should be deleted when removing the account

After deleting .sync_journal.db manually the existing sync folder connection can be reused.

TODO: check Win VFS behaviour - what happens with the dehydrated files when deleting the account?

@gabi18
Copy link
Contributor Author

gabi18 commented Sep 20, 2021

On linux (tested ownCloud-2.9.1-daily20210920.5220.AppImage on openSUSE 15.3) .sync_journal.db is deleted and therefore it's possible to reuse the sync folder.
After choosing a resolution you can connect to the server.

pick_resolution

@gabi18
Copy link
Contributor Author

gabi18 commented Sep 20, 2021

Test on Windows 10 20H2 Client 2.9.1daily20210920 with VFS ON concerning dehydrated files when removing an account:

When deleting an account a popup is shown: Really want to remove the account? .... Hint: This will not delete any files.

Really_remove_account

This isn't true in case of VFS ON: all dehydrated files got removed, only files locally available are still there, also the directory structure.

@TheOneRing TheOneRing added this to the 2.9.2 milestone Sep 21, 2021
@gabi18
Copy link
Contributor Author

gabi18 commented Sep 21, 2021

More tests with VFS ON (client 2.9.1daily20210920) reusing the sync connection (after deleting .sync_journal.db manually)

  • remove account, stop client, delete .sync_journal.db in sync folder root manually
  • restart client
  1. Connect with same account (nothing changed on server) , choose previous sync folder root
    Result:
    All files are restored, directory structure/files exactly as before

  2. Connect to a different account (with different data on server))
    Choose to keep local data
    Result:
    New dirs and files are added to the sync root -> okay
    Empty directories remain -> might be misleading

Changes on server or on client-side are synced correctly.

@gabi18
Copy link
Contributor Author

gabi18 commented Sep 22, 2021

Client version 2.7.6 and 2.8.2:
When removing an account, the .sync_xxxxx.db file got deleted from sync folder, only .owncloudsync.log stays there.
Dehydrated files are gone, directory structure remains (same as with client 2.9.1).

@TheOneRing TheOneRing linked a pull request Sep 23, 2021 that will close this issue
@gabi18
Copy link
Contributor Author

gabi18 commented Sep 27, 2021

Remark:
Removing an account ("Account" button "Remove") and "Remove sync folder connection" from "..." menu have same result:

  • dehydrated files get deleted, files local available stay in sync folder
  • folder structure remains
  • in case of VFS ON: the VFS registration for the sync folder is removed (unregister VFS)

@gabi18 gabi18 mentioned this issue Sep 27, 2021
46 tasks
@gabi18
Copy link
Contributor Author

gabi18 commented Sep 29, 2021

Tested with 2.9.1daily20210929 (build 5268):

  • remove existing account (or remove folder connection)

Result:
.sync_journal.db gets deleted from sync folder root

@gabi18
Copy link
Contributor Author

gabi18 commented Oct 4, 2021

Confirmed with client 2.9.2rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants