[QA] [Win VFS] Spinning icon remains after a folder rename on server

[gabi18]

Seen on Windows 10 20H2 with client 2.9.1daily20210920

Steps to reproduce:

• start client and 'Open folder' for an existing account
• on server: rename a folder, here: rename 'Documents' to 'Documents_admin'

Result:
The Explorer shows new name but the spinning icon for the folder remains, also after a 'Force Sync' and/or reopen the Explorer.

20210922_0818_owncloud.log.2.gz

09-22 08:23:52:347 [ info sync.propagator ]:	Starting SyncInstruction(CSYNC_INSTRUCTION_RENAME) propagation of "Documents_admin" by OCC::PropagateLocalRename(0x1817b6d0a10)
09-22 08:23:52:347 [ debug sync.propagator.localrename ]	[ OCC::PropagateLocalRename::start ]:	MOVE  "C:/Users/gabi/ownCloud/Documents"  =>  "C:/Users/gabi/ownCloud/Documents_admin"
09-22 08:23:52:347 [ debug sync.propagator ]	[ OCC::OwncloudPropagator::localFileNameClash ]:	CaseClashCheck for  "C:/Users/gabi/ownCloud/Documents_admin"
09-22 08:23:52:347 [ debug sync.database.sql ]	[ OCC::SqlQuery::bindValue ]:	SQL bind 1 -2945515776080496027
09-22 08:23:52:347 [ debug sync.database.sql ]	[ OCC::SqlQuery::exec ]:	SQL exec "SELECT path, inode, modtime, type, md5, fileid, remotePerm, filesize,  ignoredChildrenRemote, contentchecksumtype.name || ':' || contentChecksum FROM metadata  LEFT JOIN checksumtype as contentchecksumtype ON metadata.contentChecksumTypeId == contentchecksumtype.id WHERE phash=?1"
09-22 08:23:52:347 [ debug sync.database.sql ]	[ OCC::SqlQuery::bindValue ]:	SQL bind 1 -2945515776080496027
09-22 08:23:52:347 [ debug sync.database.sql ]	[ OCC::SqlQuery::exec ]:	SQL exec "DELETE FROM metadata WHERE phash=?1"
09-22 08:23:52:347 [ debug sync.database.sql ]	[ OCC::SqlQuery::exec ]:	Last exec affected 1 rows.
09-22 08:23:52:347 [ warning sync.vfs.win ]:	bool __cdecl OCC::VfsWin::setPinState(const class QString &,enum OCC::PinStateEnums::PinState) : could not make handle for "C:/Users/gabi/ownCloud/Documents" "WindowsError: ffffffff80070002: Das System kann die angegebene Datei nicht finden."
09-22 08:23:52:347 [ debug sync.database.sql ]	[ OCC::SqlQuery::bindValue ]:	SQL bind 1 1
09-22 08:23:52:347 [ debug sync.database.sql ]	[ OCC::SqlQuery::exec ]:	SQL exec "SELECT path FROM selectivesync WHERE type=?1"
09-22 08:23:52:347 [ debug sync.database ]	[ OCC::SyncJournalDb::commitInternal ]:	Transaction commit "localRename" and starting new transaction
09-22 08:23:52:347 [ info sync.propagator ]:	Completed propagation of "Documents_admin" by OCC::PropagateLocalRename(0x1817b6d0a10) with status OCC::SyncFileItem::Success
09-22 08:23:52:347 [ debug sync.statustracker ]	[ OCC::SyncFileStatusTracker::slotItemCompleted ]:	Item completed "Documents_admin" OCC::SyncFileItem::Success SyncInstruction(CSYNC_INSTRUCTION_RENAME)
09-22 08:23:52:360 [ info gui.folderwatcher ]:	Detected changes in paths: QSet("C:/Users/gabi/ownCloud/Documents")
09-22 08:23:52:360 [ debug sync.localdiscoverytracker ]	[ OCC::LocalDiscoveryTracker::addTouchedPath ]:	inserted touched "Documents"
09-22 08:23:52:360 [ debug gui.folder ]	[ OCC::Folder::slotWatchedPathChanged ]:	Changed path was touched by SyncEngine, ignoring: "C:/Users/gabi/ownCloud/Documents"
09-22 08:23:52:360 [ info gui.folderwatcher ]:	Detected changes in paths: QSet("C:/Users/gabi/ownCloud/Documents_admin")
09-22 08:23:52:360 [ debug sync.localdiscoverytracker ]	[ OCC::LocalDiscoveryTracker::addTouchedPath ]:	inserted touched "Documents_admin"
09-22 08:23:52:360 [ debug gui.folder ]	[ OCC::Folder::slotWatchedPathChanged ]:	Changed path was touched by SyncEngine, ignoring: "C:/Users/gabi/ownCloud/Documents_admin"
09-22 08:23:52:360 [ info sync.propagator ]:	Starting SyncInstruction(CSYNC_INSTRUCTION_RENAME) propagation of "Documents_admin/Example.odt" by OCC::PropagateLocalRename(0x1817b6d0a10)
09-22 08:23:52:360 [ debug sync.database.sql ]	[ OCC::SqlQuery::bindValue ]:	SQL bind 1 2526864515509545648
09-22 08:23:52:360 [ debug sync.database.sql ]	[ OCC::SqlQuery::exec ]:	SQL exec "SELECT path, inode, modtime, type, md5, fileid, remotePerm, filesize,  ignoredChildrenRemote, contentchecksumtype.name || ':' || contentChecksum FROM metadata  LEFT JOIN checksumtype as contentchecksumtype ON metadata.contentChecksumTypeId == contentchecksumtype.id WHERE phash=?1"
09-22 08:23:52:360 [ debug sync.database.sql ]	[ OCC::SqlQuery::bindValue ]:	SQL bind 1 2526864515509545648
09-22 08:23:52:360 [ debug sync.database.sql ]	[ OCC::SqlQuery::exec ]:	SQL exec "DELETE FROM metadata WHERE phash=?1"
09-22 08:23:52:360 [ debug sync.database.sql ]	[ OCC::SqlQuery::exec ]:	Last exec affected 1 rows.
09-22 08:23:52:360 [ warning sync.vfs.win ]:	bool __cdecl OCC::VfsWin::setPinState(const class QString &,enum OCC::PinStateEnums::PinState) : could not make handle for "C:/Users/gabi/ownCloud/Documents/Example.odt" "WindowsError: ffffffff80070003: Das System kann den angegebenen Pfad nicht finden."
09-22 08:23:52:360 [ debug sync.fileitem ]	[ OCC::SyncFileItem::toSyncJournalFileRecordWithInode ]:	"C:/Users/gabi/ownCloud/Documents_admin/Example.odt" Retrieved inode  243937 (previous item inode:  243937 )
09-22 08:23:52:360 [ info sync.database ]:	Updating file record for path: "Documents_admin/Example.odt" inode: 243937 modtime: 1632291501 type: CSyncEnums::ItemTypeVirtualFile etag: "4e1f4f7682701d8ff4620ac4bc2a5af4" fileId: "00000019oc3x4hdlqs3s" remotePerm: "WDNVR" fileSize: 36227 checksum: "SHA1:a2c861e88db506c0deadb9f7d78a1e27212ce9fc"

[TheOneRing]

Fixed in #9090