Windows: Enable us to support sync root path > 260 char

[TheOneRing]

No description provided.

[ownclouders]

Results for GUI-tests https://drone.owncloud.com/owncloud/client/13227/6/1

💥 The GUI tests failed.

GUI Logs: https://cache.owncloud.com/public/owncloud/client/13227/guiReportUpload/index.html

Server Logs: https://cache.owncloud.com/public/owncloud/client/13227/guiReportUpload/serverlog.log

Screenshots:

• Filenames_that_are_rejected_by_the_server_are_reported.png

[fmoc]

Please see my previous review comment.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication

[HanaGemela]

Try to sync a file which root path is > 260 char on Windows without VFS. That should work.
With VFS there should be a nice error handling

[HanaGemela]

With VFS follow #10136 to make it work as well

[TheOneRing]

Try to sync a file which root path is > 260 char on Windows without VFS. That should work. With VFS there should be a nice error handling
Not a nice error but an error

[saw-jan]

Try to sync a file which root path is > 260 char on Windows without VFS. That should work. With VFS there should be a nice error handling

@HanaGemela With or without VFS, the file with root path > 260 chars gets synced.
Syncing file:
thisfilehascharacterslongerthantwohundredandsixty/thisfilehascharacterslongerthantwohundredandsixty/thisfilehascharacterslongerthantwohundredandsixty/thisfilehascharacterslongerthantwohundredandsixty/thisfilehascharacterslongerthantwohundredandsixty/thisfilehascharacterslongerthantwohundredandsixty/afile.txt

Steps:

1. create the above file path in the server (using webUI)
2. add account to the client (with or without VFS)
3. wait for sync (sync completes)

Without changing system behavior

1. ✔️ file which root path is > 260 chars syncs without VFS
2. ✔️ file which root path is > 260 chars syncs with VFS

System (VM):
Windows: 10 build 1809
Enable Win32 long paths: Disabled
LongPathsEnabled: 0

[TheOneRing]

Same as #10136 (comment) please test a long path to a sync root not a synced file.

[saw-jan]

Same as #10136 (comment) please test a long path to a sync root not a synced file.

With or without the VFS, the long sync root path can be synced without changing system behavior.
Incorrect steps

[saw-jan]

Steps to test:

1. Create long path > 260 chars in the windows system (use terminal like git bash or https://github.com/PowerShell/PowerShell/releases)
   E.g: C:/thisfilehascharacterslongerthantwohundredandsixty/thisfilehascharacterslongerthantwohundredandsixty/thisfilehascharacterslongerthantwohundredandsixty/thisfilehascharacterslongerthantwohundredandsixty/thisfilehascharacterslongerthantwohundredandsixty/thisfilehascharacterslongerthantwohundredandsixty/ownCloud
2. Desktop client: Add account with VFS disabled and sync path pointing to the above path