Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixers for refactorings due to phpunit 7/8 deprecations #20

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

phil-davis
Copy link
Contributor

See owncloud/core#36501 for description of the phpunit deprecations and associated php-cs-fixer fixes.

Add these to the regular code-style checks so that people who add new unit tests will realise to use the newer phpunit functions/methods...

In composer.json require friendsofphp/php-cs-fixer 2.16 or later, just to make sure that all the fixers will be available.

Make this version 2.0.0 of coding-standard so that we can implement it in a controlled way - the existing version 1.0.* will continue to be used by core and app repos until we purposely change the composer.json in core and each app. At that time we would also use make test-php-style-fix to automatically apply the refactorings.

@phil-davis phil-davis merged commit 2a37dd7 into master Dec 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-phpunit-fixers-v2 branch December 9, 2019 11:45
@phil-davis
Copy link
Contributor Author

@micbar do you know how the release process happens here to make 2.0.0 and have it get onto packagist or wherever so that our CI will find it?

@micbar
Copy link

micbar commented Dec 9, 2019

not sure
@PVince81 @DeepDiver1975

@phil-davis
Copy link
Contributor Author

@DeepDiver1975 ping
Your smiling face appears as the maintainer at https://packagist.org/packages/owncloud/coding-standard

@phil-davis
Copy link
Contributor Author

The "magic" is just to make a release (which will also add a tag) here in GitHub. After 15 minutes or so, packagist will find it and publish it on packagist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants