Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust composer files and app core min-version for 'drop PHP 5.6' #99

Merged
merged 1 commit into from Mar 13, 2019

Conversation

phil-davis
Copy link
Contributor

  • adjust local composer files to PHP 7.0.8
  • bump app core min-version to 10.2

because the app is now being tested only against core stable10 upcoming 10.2 that has dropped PHP 5.6 support.

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #99   +/-   ##
========================================
  Coverage      31.2%   31.2%           
  Complexity       65      65           
========================================
  Files             6       6           
  Lines           250     250           
========================================
  Hits             78      78           
  Misses          172     172

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66fcc10...2b81ce6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #99   +/-   ##
========================================
  Coverage      31.2%   31.2%           
  Complexity       65      65           
========================================
  Files             6       6           
  Lines           250     250           
========================================
  Hits             78      78           
  Misses          172     172

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66fcc10...2b81ce6. Read the comment docs.

@phil-davis phil-davis merged commit c3a3b46 into master Mar 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the remove-php-5.6 branch March 13, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants