💀 Deathdate … and anniversary! 🎉 #472
Conversation
|
@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @Henni and @skjnldsv to be potential reviewers |
|
Not sure if I should be worried about you or me now … |
Current coverage is 12.13% (diff: 100%)@@ master #472 diff @@
==========================================
Files 45 45
Lines 816 816
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 99 99
Misses 717 717
Partials 0 0
|
| template: 'date' | ||
| }, | ||
| deathdate: { | ||
| readableName: t('contacts', 'Date of Death'), |
There was a problem hiding this comment.
Correct capitalization should be »Date of death«, only first character capitalized.
There was a problem hiding this comment.
please fix right away .... thx
no worry this introduces anniversary as well .... |
|
sync to calendar is in core - owncloud/core#25655 |
|
So @ChristophWurst noted something: Does it really make sense to save date of death for a person in Contacts? Cause … you will not contact them anymore really. I guess it makes sense to remember someone though, or just for completeness … I just wanna make sure we’re not just stupidly implementing the spec, because well, this in particular is a very slim usecase. ;) |
|
@jancborchardt A good point. We had thought of that, and from a personal perspective, I retain contacts who have died, often for a memory or commemoration - for many people it is an important a date to remember someone - as important as a birthday is of someone still alive. So it's not a huge use case, but certainly not a 'very slim' one. As people grow older, alas that usecase also grows. |
|
Ok, just wanted to make sure it’s a conscious decision adding this, not just cause you’re in the process of adding anniversary anyway. :) |
|
Our satanistic users will like that 😈 |
|
I guess there's nothing preventing future events being recorded either.. for those who are exceptionally well-planned! |
No description provided.