Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💀 Deathdate … and anniversary! 🎉 #472

Merged
merged 3 commits into from Aug 2, 2016
Merged

💀 Deathdate … and anniversary! 🎉 #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd5dd29
Adding date of death - refs #464
DeepDiver1975 Jul 29, 2016
64da342
More space for the label
DeepDiver1975 Jul 29, 2016
3aabb77
Adding anniversary
DeepDiver1975 Jul 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions css/public/style.css
View file
Open in desktop
Expand Up @@ -170,7 +170,7 @@ detailsitem {

detailsitem label {
display: inline-block;
width: 80px;
width: 100px;
padding: 7px 0px;
text-align: right;
opacity: .5;
Expand Down Expand Up @@ -265,7 +265,7 @@ detailsitem.details-item-note .icon-delete {

.select-addressbook,
.add-field {
margin-left: 83px;
margin-left: 103px;
}


Expand Down
10 changes: 10 additions & 0 deletions js/services/vCardProperties.js
View file
Open in desktop
Expand Up @@ -66,6 +66,14 @@ angular.module('contactsApp')
readableName: t('contacts', 'Birthday'),
template: 'date'
},
anniversary: {
readableName: t('contacts', 'Anniversary'),
template: 'date'
},
deathdate: {
readableName: t('contacts', 'Date of Death'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct capitalization should be »Date of death«, only first character capitalized.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix right away .... thx

template: 'date'
},
email: {
multiple: true,
readableName: t('contacts', 'Email'),
Expand Down Expand Up @@ -138,6 +146,8 @@ angular.module('contactsApp')
'impp',
'nick',
'bday',
'anniversary',
'deathdate',
'url',
'X-SOCIALPROFILE',
'note',
Expand Down