Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigger add symbol and button translation fix #510 #511

Merged
merged 1 commit into from
Sep 3, 2016

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Sep 3, 2016

Bigger "+" on the new contact button and removed unused string on the contactList component.
SCREEN
screen2

Closes #510

@mention-bot
Copy link

@skjnldsv, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @irgendwie and @jancborchardt to be potential reviewers

@skjnldsv skjnldsv added this to the 1.5 milestone Sep 3, 2016
@skjnldsv skjnldsv self-assigned this Sep 3, 2016
@MariusBluem
Copy link
Contributor

👍

@@ -10,7 +10,6 @@ angular.module('contactsApp')
ctrl.invalid = false;

ctrl.t = {
addContact : t('contacts', '+ New contact'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! 👍

@irgendwie
Copy link
Contributor

LGTM 👍

merging when travis is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants