Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vCard from the app itself #738

Merged
merged 1 commit into from Jun 10, 2022
Merged

Use vCard from the app itself #738

merged 1 commit into from Jun 10, 2022

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Jun 10, 2022

Fixes #735
Signed-off-by: Kiran Parajuli kiranparajuli589@gmail.com

Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review June 10, 2022 10:59
@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kiranparajuli589 kiranparajuli589 self-assigned this Jun 10, 2022
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment on lines -28 to +34
"vCard": false,
"_": false,
"OC": false,
"t": false,
"n": false,
"dav": false,
"OCA": false
"OCA": false,
"vCard": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be undone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

javascript-tests pipeline is failing and needs further investigation
4 participants