Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Management] Rename groups (delete already exists) #12600

Closed
LukasReschke opened this issue Dec 4, 2014 · 8 comments
Closed

[User Management] Rename groups (delete already exists) #12600

LukasReschke opened this issue Dec 4, 2014 · 8 comments

Comments

@LukasReschke
Copy link
Member

LukasReschke commented Dec 4, 2014

As an admin, I want to rename a group to make it easier for me to manage the ownCloud installation.

Acceptance Criteria:
Rename only works for local groups, as LDAP / AD groups clearly can't be renamed in ownCloud
When a group is renamed, the group is renamed for every user that is already a member of the group.
When a group is deleted, the group is deleted, but not group members - the members just lose their membership in the deleted group.
This is done via the sidebar, where next to the set groups admins can create and edit custom groups. The active group will show a control to rename and delete that group.

Remarks by Engineering:
It really means it. The group names are also used as an index. If we rename this, we must also rename any occurrence in the database. In some apps, we would also need to alter other files (mount.json for files_external if group mounts are set up). And then there are 3rd party apps we do not have control of.
We don't necessarily need to show the identifier in the user management and keep it totally internal, but we need to keep it.

Got it, the group “display name” would be different, but the index would be the same. That works...Thanks for explaining.

@LukasReschke
Copy link
Member Author

@MorrisJobke @craigpg FYI

@MorrisJobke
Copy link
Contributor

UX wise: Like the calendar rename functionality?

@PVince81
Copy link
Contributor

PVince81 commented Dec 5, 2014

Would it be easier to rather introduce display names for groups as well ?
Suggested here: #7918
(CC @Xenopathic)

@MorrisJobke
Copy link
Contributor

@PVince81 I also proposed this and this is most likely the way to go. Otherwise it will lead to a migration nightmare.

@MorrisJobke MorrisJobke removed this from the 8.0-current milestone Dec 9, 2014
@MorrisJobke MorrisJobke mentioned this issue Dec 22, 2014
27 tasks
@MorrisJobke MorrisJobke added this to the 8.1-next milestone Dec 22, 2014
@DeepDiver1975 DeepDiver1975 modified the milestones: 8.1-current, 8.2-next Mar 2, 2015
@DeepDiver1975 DeepDiver1975 modified the milestones: 8.2-next, backlog Jul 3, 2015
@ghost ghost modified the milestones: 9.0-current, backlog Nov 30, 2015
@ghost ghost modified the milestones: 9.1-next, 9.0-current Feb 23, 2016
@PVince81 PVince81 modified the milestones: 9.2, 9.1 Jul 6, 2016
@PVince81
Copy link
Contributor

PVince81 commented Jul 6, 2016

Moving enhancement to 9.2.

CC @DeepDiver1975 @dragotin

@PVince81
Copy link
Contributor

PVince81 commented Dec 22, 2016

Group display name support was added in core through #7918.

Now what remains is adjusting the local database group backend to support it and also the web UIs to support it, here's a list:

  • backend interface support: Adding group display name support in group backends #26750
  • add to local backend
    • new DB column in oc_groups for display names
  • add display name support in various places
    • users page
      • display name in dropdowns (+ group id as tooltip)
      • rename icon in left panel if backend supports display name / renaming
      • somehow let the user specify both group id + display name when creating new groups
    • various dropdowns (exclude groups from sharing, exclude groups from apps)
    • sharing autocomplete / sharee API: Adding group display name support in group backends #26750
  • import from LDAP if available ?

@PVince81
Copy link
Contributor

@pmaier1 would move to backlog for now.

The reason I worked on this was because custom groups require display name support to be able to rename them, so "backend interface support" had to be added into core.

The remaining is however nice to have for the near future I think, maybe 10.1.

@pmaier1 pmaier1 modified the milestones: backlog, 10.0 Dec 23, 2016
@FireEmerald
Copy link

Changing the displayed name of a existing group is such a basic thing - i wonder why this isn't implemented yet. So we need to create a new group and assign all rights again if we require to change the displayed name...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants