Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "part" folder for huge file operations #13756

Closed
PVince81 opened this issue Jan 29, 2015 · 5 comments
Closed

Use "part" folder for huge file operations #13756

PVince81 opened this issue Jan 29, 2015 · 5 comments

Comments

@PVince81
Copy link
Contributor

PVince81 commented Jan 29, 2015

When deleting a huge folder with subfolders, it can take a long time to move it to trash (especially if from external storage).

One idea would be to first rename the folder "test" to "test.part" to make it invisible to regular file operations. At this point neither web UI nor sync client will see it, so it will appear as deleted, while the "test.part" folder is still being moved to trash.

Such idea could in some way also be applied to cross-storage renames (the ones where copy is not avoidable). The target folder could first be written as "target.part" on the target storage, and once all files are there, rename it to the final one.

What do you think ? @schiesbn @icewind1991 @karlitschek @DeepDiver1975

@DeepDiver1975
Copy link
Member

interesting approach - this would also allow us to perform the real operation async.

@PVince81
Copy link
Contributor Author

  • use part folder when renaming folders
  • use part file for rename/copy/streamcopy

I'm setting this to 8.2 so we keep an eye on it.
If a PHP timeout would happen during a streamCopy it could result in partially written / broken files.

@PVince81
Copy link
Contributor Author

Moving this discussion to 9.0

@PVince81 PVince81 modified the milestones: 9.0-next, 8.2-current Sep 21, 2015
@PVince81 PVince81 modified the milestones: 9.1-next, 9.0-current Feb 11, 2016
@PVince81 PVince81 modified the milestones: backlog, 9.1 Jul 6, 2016
@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants