Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files deleted after recreating user #1841

Closed
seucolega opened this issue Feb 22, 2013 · 6 comments
Closed

Files deleted after recreating user #1841

seucolega opened this issue Feb 22, 2013 · 6 comments

Comments

@seucolega
Copy link

After updating the ownCloud, I had problems to access one administrator's account (admin). So I logged in with another admin's account to delete and create again the admin's account.

I followed the steps:

  • Renamed the user's folder 'files' to '_files'
  • Excluded the user
  • Renamed the folder '_files' to 'files'
  • Created the user again and login

I didn't understand why the folder was empty, all files were permanently deleted.

@VicDeo
Copy link
Member

VicDeo commented Feb 22, 2013

@seucolega newly created user always gets an empty dir so 4th step should be 3rd.

@jancborchardt
Copy link
Member

@VicDeo so an existing »files« directory is wiped, if there’s data in it? That seems to be the problem here.

@LukasReschke
Copy link
Member

@VicDeo so an existing »files« directory is wiped, if there’s data in it? That seems to be the problem here.

This is a security feature.

@VicDeo
Copy link
Member

VicDeo commented Mar 21, 2013

@jancborchardt I think it's cool to be a mighty heir of non-longer existing user due to the name collision. 💰
But @LukasReschke has different opinion.

Newly created user gets an empty directory at his disposal. It's by design.
Think of it this way: new user of a payment system has got the balance of deleted user with the same username. Is that acceptable?

@VicDeo VicDeo closed this as completed Mar 21, 2013
@jancborchardt
Copy link
Member

Of course, a new user shouldnt get the files of a previous one with the same name. But as you see from the problem which the original poster had, they should not be completely erased either.

A sane solution here might be to not erase the files if there are some existing ones, but rather move them to a folder called (username)-(some hash). That way at least the admin can recover them.

What do you think? Involuntary data loss is pretty clearly not something which should ever happen with ownCloud.

On 21.03.2013, at 21:32, VicDeo notifications@github.com wrote:

@jancborchardt I think it's cool to be a mighty heir of non-longer existing user due to the name collision.
But @LukasReschke has a different opinion.

Newly created user gets an empty directory in his disposal. It's by design.


Reply to this email directly or view it on GitHub.

@jancborchardt jancborchardt reopened this Mar 21, 2013
@jancborchardt
Copy link
Member

The proper resolution to this is not to delete the user, but to change their password.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants