Provisioning API broken on PHP 5.4

[oparoz]

A recent change seems to have broken the provisioning API and it doesn't behave properly any more on PHP 5.4 and 5.5 (probably old) on Travis when trying to create a user and verify its creation.

It works fine on PHP 5.6.

I don't have more details at this point, except that everything was fine last night.

This is what happens when I try to create a user

1) Failed to create a user via the provisioning api in OcsCreateUserCept (tests/api/OcsCreateUserCept.php)
 Step  I see xml response includes "DOMDocument"
 Fail  found in XML Response
Failed asserting that '<ocs><meta><status>failure</status><statuscode>999</statuscode><message>Invalid query, please check the syntax. API specifications are here: http://www.freedesktop.org/wiki/Specifications/open-collaboration-services. DEBUG OUTPUT:
</message></meta><data></data></ocs>' contains "<status>ok</status>".

Checking for the presence of a user still works.

Could someone please confirm that behaviour.

[oparoz]

Maybe this re-merge?
127b6e2

@DeepDiver1975 @Raydiation @MorrisJobke

[MorrisJobke]

@oparoz I tried some GET methods of the OCS API and they worked :(

[MorrisJobke]

@Xenopathic @PVince81

[MorrisJobke]

Ah right. I tried with 5.6 ...sorry

[PVince81]

Argh, not the router thing again?

[DeepDiver1975]

@oparoz can you bisect this? THX

[RobinMcCorkell]

This is highly likely to be that php://input bug...

[oparoz]

Sorry guys, #18691 didn't fix it.

 # php vendor/bin/codecept run tests/api/OcsCreateUserCest.php
Codeception PHP Testing Framework v2.1.2
Powered by PHPUnit 4.8.6 by Sebastian Bergmann and contributors.

Api Tests (3) ----------------------------------------------------------------------------------------------------------------
Create a user via the provisioning api (OcsCreateUserCest::createUser)                                                  Fail
Make sure the user exists (OcsCreateUserCest::checkUserExists)                                                          Fail
Delete the user (OcsCreateUserCest::deleteUser)                                                                         Fail
------------------------------------------------------------------------------------------------------------------------------


Time: 4.76 seconds, Memory: 20.00Mb

There were 3 failures:

---------
1) Failed to create a user via the provisioning api in OcsCreateUserCest::createUser (tests/api/OcsCreateUserCest.php)

 Step  I see xml response includes "DOMDocument"
 Fail  found in XML Response
Failed asserting that '<ocs><meta><status>failure</status><statuscode>999</statuscode><message>Invalid query, please check the syntax. API specifications are here: http://www.freedesktop.org/wiki/Specifications/open-collaboration-services. DEBUG OUTPUT:
</message></meta><data></data></ocs>' contains "<status>ok</status>".

Scenario Steps:

 6. $I->seeXmlResponseIncludes("DOMDocument")
 5. $I->seeResponseIsXml()
 4. $I->seeResponseCodeIs(200)
 3. $I->sendPOST("/ocs/v1.php/cloud/users",{"userid":"BlueDragon","password":"testBlueDragon"})
 2. $I->haveHttpHeader("Content-Type","application/x-www-form-urlencoded")
 1. $I->amHttpAuthenticated("admin","admin")


---------
2) Failed to make sure the user exists in OcsCreateUserCest::checkUserExists (tests/api/OcsCreateUserCest.php)

 Step  I see xml response includes "DOMDocument"
 Fail  found in XML Response
Failed asserting that '<ocs><meta><status>failure</status><statuscode>998</statuscode><message>The requested user could not be found</message></meta><data></data></ocs>' contains "<status>ok</status>".

Scenario Steps:

 6. $I->seeXmlResponseIncludes("DOMDocument")
 5. $I->seeResponseIsXml()
 4. $I->seeResponseCodeIs(200)
 3. $I->sendGET("/ocs/v1.php/cloud/users/BlueDragon")
 2. $I->haveHttpHeader("Content-Type","application/x-www-form-urlencoded")
 1. $I->amHttpAuthenticated("admin","admin")


---------
3) Failed to delete the user in OcsCreateUserCest::deleteUser (tests/api/OcsCreateUserCest.php)

 Step  I see xml response includes "DOMDocument"
 Fail  found in XML Response
Failed asserting that '<ocs><meta><status>failure</status><statuscode>101</statuscode><message></message></meta><data></data></ocs>' contains "<status>ok</status>".

Scenario Steps:

 6. $I->seeXmlResponseIncludes("DOMDocument")
 5. $I->seeResponseIsXml()
 4. $I->seeResponseCodeIs(200)
 3. $I->sendDELETE("/ocs/v1.php/cloud/users/BlueDragon")
 2. $I->haveHttpHeader("Content-Type","application/x-www-form-urlencoded")
 1. $I->amHttpAuthenticated("admin","admin")


FAILURES!
Tests: 3, Assertions: 9, Failures: 3.

Test is available here:
https://github.com/owncloud/gallery/blob/master/tests/api/OcsCreateUserCest.php

[RobinMcCorkell]

@oparoz Ah, good thing you have more comprehensive tests. Thanks for sending me the link, I'll try and fix it

[oparoz]

Cool :)

Try to reverse 127b6e2 and see how it goes.
Without it, it works for me

[RobinMcCorkell]

Hmm, that test works just fine on PHP 5.5.9 (Ubuntu 14.04 Docker). That was with current master.

[RobinMcCorkell]

However, the commit prior to #18691 also worked... @oparoz what OS and PHP version are you running?

[oparoz]

Travis Ubuntu 12.4 - PHP 5.4
FreeBSD 9 - PHP 5.5.28

One thing I've noticed is that once the test passes, after you've commented out the changes per example, it will pass again, after you re-implement them. Might be a cookie thing. I haven't looked at why yet. I was just surprised it did.

[RobinMcCorkell]

@oparoz I'm unable to reproduce the error on Ubuntu 12.04 running PHP 5.4.44... even without the Request patch. Everything just works.

[oparoz]

I'm going to create a branch of Gallery with just that test. That way, if it still fails, you'll be able to tell Travis what to do in case you want to debug it on there.

[oparoz]

Here you go:
https://travis-ci.org/owncloud/gallery/builds/78215826

Fails on master with any version of PHP, but still works on 8.1