[stable8.2] make swift url type configurable #21118
Conversation
|
By analyzing the blame information on this pull request, we identified @icewind1991, @MorrisJobke and @carlaschroder to be potential reviewers |
|
Needs port to master |
| @@ -77,7 +77,11 @@ protected function init() { | |||
| $serviceName = $this->params['serviceName']; | |||
| } | |||
|
|
|||
| $this->objectStoreService = $this->client->objectStoreService($serviceName, $this->params['region']); | |||
| $urlType = null; | |||
| if ($this->params['urlType']) { | |||
first of all we bring stuff to master and then backport stuff 🙈 ;) |
indeed |
|
@karlitschek Please approve this backport |
|
please backport |
|
This works nice. |
|
@butonic please submit PR against master first - I'm uncertain about the state of the CI system on stable8.2 regarding swift - failing test look ugly |
|
not 8.2.2 from my perspective because not yet merged to master and both (master and this) pr fail on unit testing 👎 |
|
looking into master pr |
|
moving to 8.2.3 - we are closing 8.2.2 tomorrow |
DeepDiver1975
modified the milestones:
8.2.3-next-maintenance,
8.2.2-current-maintenance
PVince81
changed the title
|
Ping - the master PR is merged. |
|
👍 |
[stable8.2] make swift url type configurable
|
What are the exact options, 'public, 'internal' or 'admin'? Are there any others? |
|
And which oC versions does this apply to? |
8.2.3 ;) (see on the right sidebar) |
|
@MorrisJobke, bitter experience has taught me to not rely on the milestone :) |
Okay :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Allows configuring the Interface, typically 'public, 'internal' or 'admin'
cc @felixboehm