Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user management: show password error temporary #21255

Merged
merged 1 commit into from Dec 17, 2015

Conversation

michag86
Copy link
Contributor

Fixes #21239

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @ringmaster, @MorrisJobke and @PVince81 to be potential reviewers

@MorrisJobke
Copy link
Contributor

👍

@MorrisJobke MorrisJobke added this to the 9.0-current milestone Dec 17, 2015
@MorrisJobke
Copy link
Contributor

@owncloud/javascript Please review :)

@blizzz
Copy link
Contributor

blizzz commented Dec 17, 2015

while testing I found

{"reqId":"1SQkp1HkxbWCja380dE+","remoteAddr":"127.0.0.1","app":"PHP","message":"Undefined variable: l at \/home\/blizzz\/owncloud\/dev\/master\/settings\/changepassword\/controller.php#154","level":0,"time":"2015-12-17T13:52:51+00:00","method":"POST","url":"\/master\/index.php\/settings\/users\/changepassword"}
{"reqId":"1SQkp1HkxbWCja380dE+","remoteAddr":"127.0.0.1","app":"PHP","message":"Call to a member function t() on null at \/home\/blizzz\/owncloud\/dev\/master\/settings\/changepassword\/controller.php#154","level":3,"time":"2015-12-17T13:52:51+00:00","method":"POST","url":"\/master\/index.php\/settings\/users\/changepassword"}

which is unrelated by this PR. Easy fix, will provide in a seperate PR, and with this it works as expected 👍

DeepDiver1975 added a commit that referenced this pull request Dec 17, 2015
…error-temporary

user management: show password error temporary
@DeepDiver1975 DeepDiver1975 merged commit 3818a05 into master Dec 17, 2015
@DeepDiver1975 DeepDiver1975 deleted the usermanagement-show-password-error-temporary branch December 17, 2015 15:25
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usermanagement: Password change error display behavior
5 participants