set etag and permission fields for trashbin entries #21544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @PVince81, @schiesbn and @Xenopathic to be potential reviewers |
|
👍 as discussed |
| @@ -91,6 +92,8 @@ public static function getTrashFiles($dir, $user, $sortAttribute = '', $sortDesc | |||
| 'type' => $view->is_dir($dir . '/' . $entryName) ? 'dir' : 'file', | |||
| 'directory' => ($dir === '/') ? '' : $dir, | |||
| 'size' => $size, | |||
| 'etag' => '', | |||
| 'permissions' => Constants::PERMISSION_ALL - Constants::PERMISSION_SHARE | |||
There was a problem hiding this comment.
Files can't have create permissions.
There was a problem hiding this comment.
So nothing bad really happens probably. But for cleanness.
|
... |
|
Yep, works indeed. |
|
👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Jan 15, 2016
set etag and permission fields for trashbin entries
|
@karlitschek @icewind1991 Could we backport this to stable8.1 and stable8.2? |
|
i think a backport makes sense 👍 |
This was referenced Feb 22, 2016
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly set all the fields that are expected
Fixes #21378
cc @PVince81 @schiesbn