Selecting several files in small windows requires to close sidebar per each file selected. #21698

Closed
SergioBertolinSG opened this Issue Jan 13, 2016 · 9 comments

Projects

None yet

5 participants

@SergioBertolinSG
Member

Steps to reproduce:

Using a small screen, mobile device or reduce the size of the browser until the left sidebar is hided.

  1. Select 10 files. (Close sidebar 10 times)

Expected behaviour

You are allowed to select several files quickly.

Observed behaviour

All sidebars has to be closed. Making the selection very slow and annoying.

A screen like this appears per file selected:
screen shot 2016-01-13 at 18 25 24

Master branch
{"installed":true,"maintenance":false,"version":"9.0.0.6","versionstring":"9.0 pre alpha","edition":""}

Seen in Firefox, Chrome and Safari on iPad.

@SergioBertolinSG SergioBertolinSG added this to the 9.0-current milestone Jan 13, 2016
@jancborchardt
Member

Yeah, select should clearly not open the sidebar. If I remember correctly I mentioned this in another issue as well but can't find it.

What do you think @PVince81 @owncloud/designers?

@PVince81
Collaborator

The discussion has changed several times, but it was never said that select should not open the sidebar at all.

I'm fine with changing the behavior again.

Should the sidebar auto-close if it's open when a user clicks the checkbox ?

@jancborchardt
Member

@PVince81 yeah, unfortunately one of the aspects that mainly becomes clear with daily use.

About the auto-closing: The sidebar should be closed if the selected file is any other file than the one for which the sidebar is currently open, or if multiple files are selected (since we do not do multiple files sharing etc yet).

@jancborchardt
Member

@owncloud/javascript we need to fix this for 9.0 – it makes selection on mobile completely unusable as the sidebar is always opened full-screen for every selection you make. Another point for not automatically opening it on select.

@jancborchardt jancborchardt added sev2-high and removed sev4-low labels Feb 8, 2016
@PVince81
Collaborator

The sidebar should be closed if the selected file is any other file than the one for which the sidebar is currently open

Can you elaborate ?
This sounds like the following:

  1. User selects "test1.txt" by clicking on a white space within its row
  2. System opens side bar and displays details of "test1.txt"
  3. User selects another file "test2.txt" (ie not the currently displayed one) by clicking on a white space within its row
  4. System closes sidebar

I don't think it's correct to close the sidebar in this situation.

Maybe you meant decouping the sidebar from the checkboxes ? So if you select files with the checkboxes, I proposed to always close the sidebar regardless of how many files were selected.
Every checkbox action closes the sidebar.
However if checkboxes are selected, and the user clicks in the white space, the sidebar would reopen for that specific file ? Or not ?

@PVince81
Collaborator

Let me prepare a PR for this: checkbox action always closes the sidebar.

@PVince81 PVince81 self-assigned this Feb 15, 2016
@PVince81
Collaborator

@jancborchardt here we go #22400

@MorrisJobke
Member

Maybe you meant decouping the sidebar from the checkboxes ? So if you select files with the checkboxes, I proposed to always close the sidebar regardless of how many files were selected.
Every checkbox action closes the sidebar.
However if checkboxes are selected, and the user clicks in the white space, the sidebar would reopen for that specific file ? Or not ?

Correct. I think @jancborchardt meant the checkboxes. Clicking on the whitespace beside a file should open the sidebar nevertheless, but once the selection is continued with un-/checking another check box the sidebar should close again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment