New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selecting several files in small windows requires to close sidebar per each file selected. #21698
Comments
cc @owncloud/designers |
Yeah, select should clearly not open the sidebar. If I remember correctly I mentioned this in another issue as well but can't find it. What do you think @PVince81 @owncloud/designers? |
The discussion has changed several times, but it was never said that select should not open the sidebar at all. I'm fine with changing the behavior again. Should the sidebar auto-close if it's open when a user clicks the checkbox ? |
@PVince81 yeah, unfortunately one of the aspects that mainly becomes clear with daily use. About the auto-closing: The sidebar should be closed if the selected file is any other file than the one for which the sidebar is currently open, or if multiple files are selected (since we do not do multiple files sharing etc yet). |
@owncloud/javascript we need to fix this for 9.0 – it makes selection on mobile completely unusable as the sidebar is always opened full-screen for every selection you make. Another point for not automatically opening it on select. |
Can you elaborate ?
I don't think it's correct to close the sidebar in this situation. Maybe you meant decouping the sidebar from the checkboxes ? So if you select files with the checkboxes, I proposed to always close the sidebar regardless of how many files were selected. |
Let me prepare a PR for this: checkbox action always closes the sidebar. |
@jancborchardt here we go #22400 |
Correct. I think @jancborchardt meant the checkboxes. Clicking on the whitespace beside a file should open the sidebar nevertheless, but once the selection is continued with un-/checking another check box the sidebar should close again. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Steps to reproduce:
Using a small screen, mobile device or reduce the size of the browser until the left sidebar is hided.
Expected behaviour
You are allowed to select several files quickly.
Observed behaviour
All sidebars has to be closed. Making the selection very slow and annoying.
A screen like this appears per file selected:
Master branch
{"installed":true,"maintenance":false,"version":"9.0.0.6","versionstring":"9.0 pre alpha","edition":""}
Seen in Firefox, Chrome and Safari on iPad.
The text was updated successfully, but these errors were encountered: