Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show who changed a file in the versions tab #22216

Closed
butonic opened this issue Feb 8, 2016 · 11 comments
Closed

Show who changed a file in the versions tab #22216

butonic opened this issue Feb 8, 2016 · 11 comments

Comments

@butonic
Copy link
Member

butonic commented Feb 8, 2016

While the activity app shows me who did what when, it is frustrating not to see who created a certain version in the versions tab. So, when I need to blame someone to have messed with a document my brain quickly starts to hurt when I try to match events in the two tabs.

We should somehow merge the two tabs ... or show more info in the versions tab.

Pulling @owncloud/designers for UX guidance

CC @MTRichards

@PVince81
Copy link
Contributor

PVince81 commented Feb 8, 2016

For merging activity + versions + comments, see timeline tab: #20259 (which has some technical challenges)

Regarding versions, we never store the information about who changed the file, so this would also need a new column somewhere.

@PVince81
Copy link
Contributor

PVince81 commented Feb 8, 2016

Note that one of the challenge with version + activity is that the timestamps might not match 100%.
Ideally there should be a stronger semantic connection on database level between these too.

@jancborchardt
Copy link
Member

Yeah – regarding this whole thing I can only reiterate what @PVince81 mentioned above and what I’ve been saying since ages: We need to combine everything in one stream: #20259

Sure there’s technical challenges, but since it’s such a core part of our product we should work on solving them. Currently we basically just dump database tables and that’s not a nice UX. ownCloud should feel well integrated and not like a set of features thrown together.

cc @owncloud/designers

@jancborchardt
Copy link
Member

For that reason I’d also say we should work on this for 9.1 – @MTRichards @karlitschek?

@MTRichards
Copy link
Contributor

Definitely worth considering - not sure how hard this is, or how it will stack up - but yes.

@MTRichards MTRichards modified the milestones: 9.1-next, backlog Feb 9, 2016
@karlitschek
Copy link
Contributor

yes. i agree.

@PVince81
Copy link
Contributor

PVince81 commented Feb 9, 2016

Are you guys agreeing with the ticket title "Show who changed a file in the versions tab" or with the more extended timeline unification that @jancborchardt proposed here #20259

The timeline unification is a bigger beast, there are some challenges to work through, design-wise and architecture-wise. (which I will list in the linked ticket at some point when I have some time after the freeze)

@karlitschek
Copy link
Contributor

Well it's all about steps in my opinion :-) I agree with the ultimate vision of @jancborchardt But we might have to take a few smaller steps before we get there. Showing who created a revision might be an intermediate step. Let's discuss later for 9.1 what we can do when.

@jancborchardt
Copy link
Member

Cool, thanks for putting it in the 9.1 milestone!

@PVince81 PVince81 modified the milestones: 9.1-current, 9.2-next Jun 14, 2016
@PVince81
Copy link
Contributor

PVince81 commented Dec 8, 2016

Best would be if the versions app would simply store the user id of who made the change and expose that in the versions tab.

Moving to backlog for now @pmaier1

@PVince81 PVince81 modified the milestones: backlog, 10.0 Dec 8, 2016
@pmaier1
Copy link
Contributor

pmaier1 commented Dec 13, 2016

@PVince81 Yup. When we do it, we should do it properly as you suggested #20259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants