files_sharing is missing loadAdditionalScripts

[oparoz]

It's currently not possible to safely add Javascript to files_sharing as it's not dispatching the loadAdditionalScripts event.
Until this is fixed, core and any installed apps will be polluted by apps which add their scripts to app.php without making any checks to make sure they're on the page they target, leading to broken apps and core.

[nickvergessen]

What do you mean? it should dispatch the event on the public page?

[oparoz]

it should dispatch the event on the public page?

Exactly, allowing apps to behave properly by only loading their scripts on pages firing the loadAdditionalScripts event.

[PVince81]

backlog for now, PRs welcome

[Rello]

Hello,

any plan to fix this right now?
seems was fixed in NC already. for now, the "proper" code with

$eventDispatcher->addListener('OCA\Files_Sharing::loadAdditionalScripts',
does not trigger in OC.

e.g. gallery has now 2 versions per cloud which could be avoided I guess?
https://github.com/owncloud/gallery/blob/master/appinfo/app.php#L61-L67

https://github.com/nextcloud/gallery/blob/master/appinfo/app.php#L77

I would like to avoid this for the Audio Player in my case

[PVince81]

I'd be fine adding this event if needed. Mind submitting a PR ?

[Rello]

@PVince81 I don´t have an idea on how to implement this. any chance that this is being provided by oC until the next release?

[PVince81]

@Rello please test with #31480 and let me know if it works for you

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.