remember email when setting expiration date

[ChristophWurst]

fixes #22947

[mention-bot]

By analyzing the blame information on this pull request, we identified @PVince81, @blizzz and @rullzer to be potential reviewers

[ChristophWurst]

@jancborchardt @butonic if the order is changed so the email field is shown as last element here, the expiration checkbox is shown above the 'share link' checkbox:

That makes the usability even worse, because you don't have the option to set an expiration date if it's not a link share…
I guess we have to restructure those views and make the expiration stuff a sub-view of the link sharing view.

[jancborchardt]

I guess we have to restructure those views and make the expiration stuff a sub-view of the link sharing view.

For sure … the order should be:

• Share with others
• Share link
  • Password protect
  • Set expiration date
  • Email link

[ChristophWurst]

@jancborchardt this is what it looks like now (I updated the commit):

I'm not sure if it's clear what the different input fields are used for. Should we add some separation between the share information and the email form?

[jancborchardt]

Maybe it should be a button »Send link via email« by default. On clicking, the input field appears, with an icon-confirm button on the right (like the integrated button on the log in page, not a separate line). What do you think?

[PVince81]

Let's make the label say "Send link via email" for now for a backportable solution.

[ChristophWurst]

@PVince81 It already says 'Send link via email' ;-)

[PVince81]

Ah nice... was looking at the old screenshot

[PVince81]

Tested, works 👍

@karlitschek backport for v9.0.2 ? (blue)

[PVince81]

@karlitschek also v8.2.4 apparently

[PVince81]

Needs a second reviewer @rullzer @jancborchardt

[karlitschek]

great. please backport :+1

[jancborchardt]

Nice

[ChristophWurst]

Backport 8.2: #24152
Backport 9: #24153

Note that I backported the simple fix for the actual issue, not the refactoring of the views which might break stuff.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.