Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 byte unicode in comments #24009

Closed
karlitschek opened this issue Apr 14, 2016 · 11 comments
Closed

4 byte unicode in comments #24009

karlitschek opened this issue Apr 14, 2016 · 11 comments

Comments

@karlitschek
Copy link
Contributor

We should make sure that we support 3 byte unicode also in comments with databases that only support 3byte like mysql.
For example by an additional manual php encoding step of the affected characters without encoding the complete string.

@blizzz @PVince81 @cmonteroluque

@ghost ghost added this to the 9.1-current milestone Apr 14, 2016
@DeepDiver1975
Copy link
Member

@dragotin already reported this

@SergioBertolinSG
Copy link
Contributor

Related: #17978

@DeepDiver1975
Copy link
Member

we support 3 byte unicode

@karlitschek 4 byte I assume?

@ghost
Copy link

ghost commented Apr 18, 2016

I presume this is for old versions of MySQL before utf8mb4 support?

@DeepDiver1975
Copy link
Member

utf8mb4 support?

we do not support utf8mb4 yet - there are many issues related - see #17978

@ghost
Copy link

ghost commented Apr 19, 2016

right, I thought the idea was to resolve that for MySQL 5.5 and above, or did I get the point of this issue wrong?

@DeepDiver1975
Copy link
Member

We are facing many issues with mysql regarding 4 bytes ....

  • index length are different which has to be addressed by special mysql config options
  • some tables are exceeding the max size - we know at least of the activities table

@nickvergessen
Copy link
Contributor

I tested the following apps, only activity needed a fix for now:

  - activity: 2.3.2
  - admin_audit: true
  - announcementcenter: 1.2.0
  - calendar: 1.1
  - comments: 0.3.0
  - dav: 0.2.3
  - encryption: 1.3.0
  - enterprise_key: true
  - federatedfilesharing: 0.2.0
  - federation: 0.1.0
  - files: 1.5.1
  - files_antivirus: true
  - files_drop: 0.5.0
  - files_external: 0.6.0
  - files_ldap_home: true
  - files_pdfviewer: 0.8
  - files_sharing: 0.10.0
  - files_texteditor: 2.1
  - files_trashbin: 0.9.0
  - files_versions: 1.3.0
  - firewall: 2.4.0
  - firstrunwizard: 1.1
  - mail: 0.4.2
  - notifications: 0.3.0
  - password_policy: true
  - provisioning_api: 0.5.0
  - search_lucene: true
  - sharepoint: true
  - systemtags: 0.3.0
  - systemtags_management: 0.2.0
  - templateeditor: 0.1
  - testing: 0.1.0
  - updatenotification: 0.2.0
  - user_ldap: 0.9.0
  - windows_network_drive: 0.2.33
  - workflow: 0.2.2

@DeepDiver1975
Copy link
Member

I tested the following apps, only activity needed a fix for now:

@nickvergessen thanks a lot!

@ghost ghost mentioned this issue Apr 24, 2016
@DeepDiver1975 DeepDiver1975 modified the milestones: 9.2-next, 9.1-current Jun 17, 2016
@PVince81
Copy link
Contributor

PVince81 commented Nov 3, 2016

Closing as duplicate of #4513

@PVince81 PVince81 closed this as completed Nov 3, 2016
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants