Versions on external storage never expire

[PVince81]

Steps

1. Mount an external storage (ex: SMB) as "/smb" system-wide, apply to all users
2. Login as any user
3. Create a file "/smb/test.txt"
4. Edit the file and save many times to create 10-20 versions
5. Check the version files for that user: find data/user1 -iname \*.v\*
6. update oc_jobs set last_run=0
7. Run cron.php

Expected result

Some version expired

Actual result

No versions expired.

Versions

ownCloud 9.0.1

The reason is because the expire() method calls getUidAndFilename and the external storage has no owner, so it bails out with NoUserException without doing any expiration.

According to @schiesbn, versions on system-wide ext storage are always specific to the current user viewing the folder. So the correct logic would be to make it fallback to the user that was specified in the expire job.

CC @nickvergessen @VicDeo

[PVince81]

Looks like the code in getUidAndFilename is very old, it assumes that the owner can be another user. This is obsolete because since the introduction of expire background jobs, we only ever expire for the user specified in the expire job. For shared folders, the expire job is only created for owners even when a recipient edited a file.

This means that as part of this fix we can get rid of getOwner() and always use the expire job user.
It would also fix the case with external storage where we need to use that user too.

[PVince81]

@VicDeo can you take care of this ?

[PVince81]

Fix is here #26601

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.