normalize root before setting it in FilesView

[georgehrke]

fixes #21173

please test @PVince81 @oparoz

[georgehrke]

also cc @tigermick @davivel

[nickvergessen]

Also @icewind1991

[oparoz]

Looking at how the tests fail I'm guessing this isn't going to be that simple :(

[PVince81]

Yeah, that is dangerous territory... especially due to the unlogical and inconsistent way how the View is used.

[georgehrke]

In my case $root was /admin// and the two slashes caused the bug.

[PVince81]

So far I'd suggest putting on gloves and only fixing the problem in the calling code only, remove the duplicate slash if needed.

[tigermick]

@PVince81 @oparoz @georgehrke it's working for me ! My problem about thumbnails in external local storage in owncloud app is solved !
Thank you very much !

[georgehrke]

I'm not sure if fixing only the external storage when using the thumbnail API is the best approach here.
The problem comes down to this function:

https://github.com/owncloud/core/blob/ed7e009e056cb46b67aba8827efb5fdb3961de1c/lib/private/Files/Mount/MountPoint.php#L190L198

$path has too many slashes, therefore strlen($this->mountPoint) won't work properly.

cc @icewind1991

[PVince81]

Too bad we don't have a "comparePath" function...

[georgehrke]

What about normalizing both $path and $this->mountPoint?

[PVince81]

or use some ltrim($path, '/') magic before concat, if that's even possible

[icewind1991]

Would probably be sense to normalize the incoming path in getInternalPath iirc, the mountpoint is already normalized

[georgehrke]

okay, will try it :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.