Do not save the language as request lang for apps when we didn't find… #24432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @LukasReschke, @MorrisJobke and @bartv2 to be potential reviewers |
|
good debugging :-) Please backport 👍 |
|
Tested and works 👍 |
MorrisJobke
deleted the
issue-24270-never-save-app-language-into-request-lang
branch
|
Backport in #24441 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… any
Fix #24270
The problem why this only happens with IE, Edge and Safari is, that Chrome and Firefox send en as accept language by default as well, instead of only your OS language.
Since we find en for all apps, we never reached the end of the loop and returned with an available language instead.
There the requestLanguage is only set with
$app === nullalready and only this last occurance was missing it.@PluueeR @CCXX2016 @pako81 @MorrisJobke please test
@karlitschek should backport to 9.0.x