Construct path to the version file from the current directory and fil… #24673
Conversation
|
By analyzing the blame information on this pull request, we identified @schiesbn, @bartv2 and @icewind1991 to be potential reviewers |
| } else { | ||
| $versionsBegin = strrpos($file['path'], '.v'); | ||
| $versionsBegin = strrpos($$filePath, '.v'); |
There was a problem hiding this comment.
two dollars? looks suspicious
Mind adjusting the unit test as well to properly cover this, if possible ?
There was a problem hiding this comment.
@PVince81 sorry, it slipped through. Surely only one.
I don't know how to reproduce it.
The only thing I know that it works and that getDirectoryContents produces path relative to datadir instead if view root under some unclear conditions.
|
Weird, so this means we can't trust the output of Would be good to find out what the root cause is. |
|
@VicDeo can you add a unit test ? |
|
You can't trust the output of
The difference between the two is due to legacy reasons and I'm not sure if I can fix |
|
@icewind1991 @VicDeo so should we merge this without unit tests ?? |
|
@PVince81 |
|
Ok then... @icewind1991 can you confirm that this PR is safe ? |
|
👍 looks good |
|
Ok, thanks guys. I rebased one last time for CI. 👍 |
|
@cmonteroluque initailly reported for 8.2. Backport? |
|
@VicDeo okay please backport down to 8.2 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
…ename. Fixes #22450