Fix logClientIn for non-existing users #26292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for two factor enforcement would return true for non-existing users. This fix makes it return false in order to be able to perform the regular login which will then fail and return false. This prevents throwing PasswordLoginForbidden for non-existing users.
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChristophWurst, @icewind1991 and @DeepDiver1975 to be potential reviewers. |
|
Please review @DeepDiver1975 @jvillafanez @VicDeo |
DeepDiver1975
approved these changes
Oct 7, 2016
| @@ -384,6 +384,32 @@ public function testLogClientInNoTokenPasswordWith2fa() { | |||
| $userSession->logClientIn('john', 'doe', $request); | |||
| } | |||
|
|
|||
| public function testLogClientInUnexist() { | |||
| $manager = $this->getMockBuilder('\OC\User\Manager') | |||
There was a problem hiding this comment.
general note: I prefer to use \OC\User\Manager::class instead of the string name - helps when searching by type in ide and anyhow looks cleaner to me.
There was a problem hiding this comment.
okay... thing is I just copy-pasted the previous test and adjusted it.
Noted for the future, there's a lot to adjust.
|
👍 |
|
backporting .... |
DeepDiver1975
pushed a commit
that referenced
this pull request
Oct 7, 2016
The check for two factor enforcement would return true for non-existing users. This fix makes it return false in order to be able to perform the regular login which will then fail and return false. This prevents throwing PasswordLoginForbidden for non-existing users.
PVince81
pushed a commit
that referenced
this pull request
Oct 10, 2016
The check for two factor enforcement would return true for non-existing users. This fix makes it return false in order to be able to perform the regular login which will then fail and return false. This prevents throwing PasswordLoginForbidden for non-existing users.
DeepDiver1975
added a commit
that referenced
this pull request
Oct 10, 2016
The check for two factor enforcement would return true for non-existing users. This fix makes it return false in order to be able to perform the regular login which will then fail and return false. This prevents throwing PasswordLoginForbidden for non-existing users.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevents throwing PasswordLoginForbidden for non-existing users.
Related Issue
Fixes #26123
Motivation and Context
The check for two factor enforcement would return true for non-existing
users. This fix makes it return false in order to be able to perform
the regular login which will then fail and return false.
How Has This Been Tested?
See original steps.
Also enable two factor auth and check that for existing users the exception is still PasswordLoginForbidden in the DAV response.
Screenshots (if appropriate):
Types of changes
Checklist:
Backports