We need to ensure that the app holding the objectstore implementation is loaded #26299
Conversation
|
@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @PVince81 and @icewind1991 to be potential reviewers. |
|
Code makes sense, can't test right now, missing infrastructure. |
| $name = $config['class']; | ||
| if (strpos($name, 'OCA\\') === 0 && substr_count($name, '\\') >= 2) { | ||
| $segments = explode('\\', $name); | ||
| OC_App::loadApp(strtolower($segments[1])); |
There was a problem hiding this comment.
Shouldn't this happen automatically already ? Maybe load all apps of type "filesystem" here instead ?
There was a problem hiding this comment.
(side note: we might want to introduce a new app type "storage" or "storage provider" to accomodate for future separate files_external storage apps and maybe home storage providers)
There was a problem hiding this comment.
Especially during installation and upgrade apps are not loaded
There was a problem hiding this comment.
Ok. And is this kind of app name finding magic based on class name copied from somewhere else ? Is it reliable ? (I guess it is for the few implementations we know)
|
finally got to test this, nice! 👍 |
|
if #26299 (comment) is reliable and isn't a newly invented concept then I'm fine |
|
#26299 (diff) is a workaround for the objectstore app. when we finally implement an explicit way of setting up storages (like an fstab) we can get rid of it. |
|
backporting ... |
|
Backports were merged, removing label |
|
There might be a problem when the objectstore version increases: https://github.com/owncloud/core/blob/master/lib/private/legacy/app.php#L151 self updating doesnt work then ... |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
In some cases the app is not yet loaded before loading the objectstore class.
This fixes this issue.
Related Issue
fixes owncloud/objectstore#38
Types of changes
Checklist: