[stable9] Exclude more invalid chars from files UI path #26475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent newlines and zero byte chars to be used in files UI URL and redirect to root if one is detected. Added additional hardening in case the request fails with 400 or the XMLHttpRequest throw a DOMException, both can happen with invalid paths as well.
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @icewind1991 and @MorrisJobke to be potential reviewers. |
9 tasks
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed backport of #26461 to stable9.
Retested, still works.
Please review @DeepDiver1975 @PhilippSchaffrath