Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User without permissions is not warned when moving an external storage folder #26671

Closed
SergioBertolinSG opened this issue Nov 21, 2016 · 9 comments

Comments

@SergioBertolinSG
Copy link
Contributor

SergioBertolinSG commented Nov 21, 2016

Steps to reproduce:

  1. Enable files_external app.
  2. Using admin set up a mount point called External.
  3. As a regular user not admin try to move External folder into another folder.

Expected behaviour:

A warning appears telling the user why he cannot move that folder.

Actual behaviour

It doesn't happen but the user is not warned.

Server configuration

Operating system:
Ubuntu 16.04

Web server:
Apache

Database:
MySQL

PHP version:
7.0

ownCloud version: (see ownCloud admin page)
Current master
{"installed":true,"maintenance":false,"needsDbUpgrade":false,"version":"9.2.0.3","versionstring":"9.2.0 pre alpha","edition":"","productname":"ownCloud"}

Updated from an older ownCloud or fresh install:
Fresh

The content of config/config.php:


Are you using external storage, if yes which one: local/smb/sftp/...
Yes, SFTP

Are you using encryption:
No

Logs



Client configuration

Chrome.

@SergioBertolinSG SergioBertolinSG changed the title User without permissions is not warned when moving an external storage User without permissions is not warned when moving an external storage folder Nov 21, 2016
@SergioBertolinSG
Copy link
Contributor Author

cc @cdamken @pmaier1

@cdamken
Copy link
Contributor

cdamken commented Nov 21, 2016

Thanks @SergioBertolinSG

@pmaier1
Copy link
Contributor

pmaier1 commented Nov 22, 2016

A warning would be nice to explain to users why they can not move an external storage folder like they can do with e.g. shared folders. However, it would be even nicer to be able to move such a folder around as you wish.

@SergioBertolinSG
Copy link
Contributor Author

@PVince81 what do you think about regular users moving global external folders in their filesystem without affecting other users? It is feasible?

At the moment I think this is the expected behaviour as the administrator set up those folders for all users at once.

Not sure if this behaviour change is too complex for files external app.

@PVince81
Copy link
Contributor

It is too complex for now with the current data structure, and we really don't want to mess / split / convert the admin-side configuration every time a user decides to have their own way.

However if we want this long term, we could leverage the new oc_mounts table to make it possible for users to move any of their mounts. But before we can do this, oc_mounts needs to become an authoritative fstab like list: #26190
Because currently it's just a cache of existing mounts, you cannot change anything there. The contents of it is dictated by the sharing and ext storage apps.

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically closed.

@stale stale bot closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants