Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escape filter in search #27900

Merged
merged 1 commit into from May 16, 2017
Merged

escape filter in search #27900

merged 1 commit into from May 16, 2017

Conversation

peterprochaska
Copy link
Contributor

Description

Escape the filter parameter in error message

Motivation and Context

Make owncloud more secure

How Has This Been Tested?

Inject HTML Code and the error message is HTML-Code free

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented May 16, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@peterprochaska peterprochaska added this to the 10.0.1 milestone May 16, 2017
@peterprochaska peterprochaska force-pushed the remove-single-quote-around-search-query branch 2 times, most recently from e8bc989 to be82dba Compare May 16, 2017 09:17
@peterprochaska peterprochaska force-pushed the remove-single-quote-around-search-query branch from be82dba to b523171 Compare May 16, 2017 09:25
@PVince81
Copy link
Contributor

hmmm okay 👍

@PVince81 PVince81 merged commit 6e5a782 into master May 16, 2017
@PVince81 PVince81 deleted the remove-single-quote-around-search-query branch May 16, 2017 12:16
@PVince81
Copy link
Contributor

Backport or not critical enough ? @Peter-Prochaska @DeepDiver1975

@peterprochaska
Copy link
Contributor Author

peterprochaska commented May 16, 2017 •
edited

backport to 9.1 #27903
backport to 9 #27904

@PVince81
Copy link
Contributor

stable8.2: #27992

@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
4 - To release security Type:Bug
Projects
None yet
Milestone
10.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterprochaska @CLAassistant @PVince81 @DeepDiver1975