Webdav: Could not rename part file to final file due to Quota limit #29103

htwsaaraub · 2017-09-27T08:11:01Z

Steps to reproduce

Connect to Owncloud WebDav with Windows Explorer Map Network Drive
Use https://owncloud.local/remote.php/dav/files/USERNAME/
Try to Copy a File to a Owncloud Directory witch is a External SMB Share

Expected behaviour

The User Quota is set to 1MB. The File to Copy is bigger than the Quota. With Files smaler than the Quota it Works as Expected, but not for bigger Files

There should be a Option for Owncloud Configuration to not Apply Quota to External SMB Shares.
For SMB Shares the Quota of the Windows Server should be the only reasonable Quota.

Actual behaviour

Windows Trys to Upload the File, but the Message appears: Could not read from Sorce or Destination

Server configuration

Operating system: Debian 4.9.30-2+deb9u3 (2017-08-06) x86_64

Web server: Apache/2.4.25 (Debian)

Database: Ver 15.1 Distrib 10.1.23-MariaDB

PHP version: PHP Version 5.6.30-0+deb8u1

ownCloud version: 10.0.3 (stable)

Updated from an older ownCloud or fresh install: Upgrade from 10.0.2

Where did you install ownCloud from: Debian Packages

Are you using external storage, if yes which one: smb...

Are you using encryption: no

Are you using an external user-backend, if yes which one: LDAP Webdav..

Client configuration

Browser: Google Chrome Version 60.0.3112.113

Operating system: Windows 10 Version 1703 (Build 15063.632)

Logs

Web server error log

134.96.211.82 - - [27/Sep/2017:09:36:11 +0200] "HEAD /remote.php/dav/files/Sven.Schneider/Tausch/UPDATE_INFO.PDF HTTP/1.1" 401 745 "-" "Microsoft-WebDAV-MiniRedir/10.0.15063"
134.96.211.82 - Sven.Schneider [27/Sep/2017:09:36:11 +0200] "HEAD /remote.php/dav/files/Sven.Schneider/Tausch/UPDATE_INFO.PDF HTTP/1.1" 200 953 "-" "Microsoft-WebDAV-MiniRedir/10.0.15063"
134.96.211.82 - Sven.Schneider [27/Sep/2017:09:36:12 +0200] "PUT /remote.php/dav/files/Sven.Schneider/Tausch/UPDATE_INFO.PDF HTTP/1.1" 500 910 "-" "Microsoft-WebDAV-MiniRedir/10.0.15063"
134.96.211.82 - Sven.Schneider [27/Sep/2017:09:36:13 +0200] "DELETE /remote.php/dav/files/Sven.Schneider/Tausch/UPDATE_INFO.PDF HTTP/1.1" 204 685 "-" "Microsoft-WebDAV-MiniRedir/10.0.15063"

ownCloud log (data/owncloud.log)

{"reqId":"1mZJzSwHluxXhiTx1DnV","level":3,"time":"2017-09-27T07:28:06+00:00","remoteAddr":"134.96.211.82","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"\/remote.php\/dav\/files\/Sven.Schneider\/Tausch\/Scan\/UPDATE_INFO.PDF","message":"renaming part file to final file failed"}
{"reqId":"1mZJzSwHluxXhiTx1DnV","level":4,"time":"2017-09-27T07:28:06+00:00","remoteAddr":"134.96.211.82","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"\/remote.php\/dav\/files\/Sven.Schneider\/Tausch\/Scan\/UPDATE_INFO.PDF","message":"Exception: {\"Message\":\"HTTP\\\/1.1 500 Could not rename part file to final file\",\"Exception\":\"Sabre\\\\DAV\\\\Exception\",\"Code\":0,\"Trace\":\"#0 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(1129): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\File->put(Resource id #66)\\n#1 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(513): Sabre\\\\DAV\\\\Server->updateFile('files\\\/Sven.Schn...', Resource id #66, NULL)\\n#2 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpPut(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#3 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#4 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(479): Sabre\\\\Event\\\\EventEmitter->emit('method:PUT', Array)\\n#5 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#6 \\\/var\\\/www\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Server.php(234): Sabre\\\\DAV\\\\Server->exec()\\n#7 \\\/var\\\/www\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v2\\\/remote.php(31): OCA\\\\DAV\\\\Server->exec()\\n#8 \\\/var\\\/www\\\/owncloud\\\/remote.php(165): require_once('\\\/var\\\/www\\\/ownclo...')\\n#9 {main}\",\"File\":\"\\\/var\\\/www\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/File.php\",\"Line\":212,\"User\":\"Sven.Schneider\"}"}

The text was updated successfully, but these errors were encountered:

PVince81 · 2017-10-09T14:15:00Z

By default the quota should never be applied to external storages. This is likely another bug / regression 😦

PVince81 · 2017-10-10T09:08:45Z

I wrote an automated test here #29193 but it seems to work fine with quota and external storage.

Will need further investigation and manual reproduction.

@htwsaaraub mind posting your config.php in an anonymized form ?

htwsaaraub · 2017-10-11T13:38:35Z

@PVince81 Here is my config.php

$CONFIG = array (
'instanceid' => 'XXX',
'passwordsalt' => 'XXX',
'trusted_domains' =>
array (
0 => 'XXX.XXX.XXX.XXX',
1 => 'name.domain.de',
),
'skeletondirectory' => '',
'datadirectory' => '/var/www/owncloud/data',
'dbtype' => 'mysql',
'version' => '10.0.3.3',
'dbname' => 'owncloud',
'dbhost' => '127.0.0.1',
'dbtableprefix' => 'oc_',
'dbuser' => 'XXX',
'dbpassword' => 'XXX',
'installed' => true,
'ldapIgnoreNamingRules' => false,
'theme' => 'htwsaar',
'maintenance' => false,
'forcessl' => true,
'loglevel' => '3',
'activity_expire_days' => 180,
'preview_max_x' => 100,
'preview_max_y' => 100,
'enable_previews' => false,
'preview_max_scale_factor' => 1,
'log_rotate_size' => 104857600,
'secret' => 'XXX',
'asset-pipeline.enabled' => true,
'trashbin_retention_obligation' => '30, auto',
'filelocking.enabled' => 'true',
'memcache.local' => '\OC\Memcache\Redis',
'memcache.distributed' => '\OC\Memcache\Redis',
'memcache.locking' => '\OC\Memcache\Redis',
'redis' =>
array (
'host' => 'localhost',
'port' => 6379,
'timeout' => 0,
'dbindex' => 0,
),
'updatechecker' => false,
);

PVince81 · 2017-10-12T09:18:29Z

I could not reproduce this issue:

Setup v10.0.3
Login as admin
Setup a SMB storage and mount it to "/smb" for all users
Set the quota for the admin to "1 MB"
Using a Webdav client (I used cadaver), connect to "remote.php/dav/admin/smb"
PUT a file bigger than 1 MB to this location

The file is uploaded properly.

And now I also tested with the ownCloud desktop client and uploading a 100 MB file (chunking) to "/smb" works fine.
And with the web UI the big file works fine too.

I don't think this is related to quota but maybe a problem with renaming files on an SMB external storage. Can you try directly renaming a file through Webdav (that Windows mount) to a different name ?

PVince81 · 2017-10-12T09:19:22Z

do you have the smbclient PHP module installed and enabled ? (aka php5-libsmbclient)

htwsaaraub · 2017-10-12T13:04:46Z

@PVince81 Yes, I use the smbclient PHP module

libsmbclient:amd64 2:4.5.12+dfsg-2 amd64 shared library for communication with SMB/CIFS servers

I use the Windows 10 integrated Webdav Client
Connect to https://xxx.xxx.xxx/remote.php/dav/files/$username
Quota for the User is set to 1 MB
Copy a File bigger than the Quota in the User Root Folder immediately throws the Quota exeeded message. (as expected)
Copy a File bigga than the Quota to ROOT\SMB the Webdav Client tries to upload the File. The Copy Process shows the progress and bevor it'ts completed it throws the Quota exeeded message.

In the owncloud.log File the following message is logged.

{"reqId":"mvPp9MqC1dZgvXPkTk7K","level":3,"time":"2017-10-12T12:51:03+00:00","remoteAddr":"134.96.211.82","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"\/remote.php\/dav\/files\/Sven.Schneider\/Software\/putty-64bit-0.70-installer.msi","message":"renaming part file to final file failed"}
{"reqId":"mvPp9MqC1dZgvXPkTk7K","level":4,"time":"2017-10-12T12:51:03+00:00","remoteAddr":"134.96.211.82","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"\/remote.php\/dav\/files\/Sven.Schneider\/Software\/putty-64bit-0.70-installer.msi","message":"Exception: {\"Message\":\"HTTP\\\/1.1 500 Could not rename part file to final file\",\"Exception\":\"Sabre\\\\DAV\\\\Exception\",\"Code\":0,\"Trace\":\"#0 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(1129): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\File->put(Resource id #64)\\n#1 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(513): Sabre\\\\DAV\\\\Server->updateFile('files\\\/Sven.Schn...', Resource id #64, NULL)\\n#2 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpPut(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#3 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#4 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(479): Sabre\\\\Event\\\\EventEmitter->emit('method:PUT', Array)\\n#5 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#6 \\\/var\\\/www\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Server.php(234): Sabre\\\\DAV\\\\Server->exec()\\n#7 \\\/var\\\/www\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v2\\\/remote.php(31): OCA\\\\DAV\\\\Server->exec()\\n#8 \\\/var\\\/www\\\/owncloud\\\/remote.php(165): require_once('\\\/var\\\/www\\\/ownclo...')\\n#9 {main}\",\"File\":\"\\\/var\\\/www\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/File.php\",\"Line\":212,\"User\":\"Sven.Schneider\"}"}

Apache Owncloud.log

[12/Oct/2017:14:50:58 +0200] "PROPFIND /remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi HTTP/1.1" 404 1276 "-" "Microsoft-WebDAV-MiniRedir/10.0.15063"
[12/Oct/2017:14:50:58 +0200] "PUT /remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi HTTP/1.1" 201 783 "-" "Microsoft-WebDAV-MiniRedir/10.0.15063"
[12/Oct/2017:14:50:59 +0200] "LOCK /remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi HTTP/1.1" 200 1450 "-" "Microsoft-WebDAV-MiniRedir/10.0.15063"
[12/Oct/2017:14:51:00 +0200] "PROPPATCH /remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi HTTP/1.1" 207 1444 "-" "Microsoft-WebDAV-MiniRedir/10.0.15063"
[12/Oct/2017:14:51:01 +0200] "HEAD /remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi HTTP/1.1" 401 745 "-" "Microsoft-WebDAV-MiniRedir/10.0.15063"
[12/Oct/2017:14:51:01 +0200] "HEAD /remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi HTTP/1.1" 200 1015 "-" "Microsoft-WebDAV-MiniRedir/10.0.15063"
[12/Oct/2017:14:51:01 +0200] "PUT /remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi HTTP/1.1" 500 910 "-" "Microsoft-WebDAV-MiniRedir/10.0.15063"
[12/Oct/2017:14:51:03 +0200] "DELETE /remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi HTTP/1.1" 204 791 "-" "Microsoft-WebDAV-MiniRedir/10.0.15063"

So, the Problem is not Quota, it's renaming files when Uploading with intregrated Windows Webdav Client.
Renaming existing Files in WebDav works as expected.

PVince81 · 2017-10-13T07:11:28Z

@htwsaaraub please check that you have the PHP module for libsmbclient. The package you pointed at is the actual C/C++ library but not the PHP wrapper for it. The module can be installed with sudo pecl install smbclient, you might also be able to find a package called php5-libsmbclient or something similar, depending on your sources.

Still strange that rename works for regular files but not part files.

htwsaaraub · 2017-10-13T08:15:07Z

I just installed php-smbclient from Debian Sources via apt.

php-smbclient amd64 0.8.0-3

phpinfo:

libsmbclient Support | enabled
libsmbclient Version | 0.6.1

I also Installed smbclient from github
https://github.com/eduardok/libsmbclient-php

libsmbclient-php 0.90 installed successfully.
This smbclient module doesn't show up in php.ini, although extension=smbclient.so is set.

There is no change in WebDav. Same rename File error as before.

PVince81 · 2017-10-13T08:47:04Z

@jvillafanez does this ring any bells ? Part file cannot be renamed to final file on SMB storage but regular renames work there.

jvillafanez · 2017-10-16T07:29:39Z

The exception is thrown in https://github.com/owncloud/core/blob/v10.0.3/apps/dav/lib/Connector/Sabre/File.php#L212

I suggest to add in the line above the following log for debugging:

\OCP\Util::writeLog('webdav', 'run -> "' . print_r($run, true) . '" renameok -> "' . print_r($renameOkay, true) . '" file_exists -> "' . print_r($fileExists, true) . '"', \OCP\Util::ERROR);

I expect a log message like:

run -> "" renameok -> "" file_exists -> ""

with some additional "undefined variable: $renameOk" and "undefined variable: $fileExists"

If this is the case some pre hook might be causing the failure. You might want to disable non-default apps to track which one is causing problems.

htwsaaraub · 2017-10-19T15:40:11Z

I added the line for debugging. Here is the result.

{"reqId":"zF7U19o8WQBhsm1AlVyV","level":3,"time":"2017-10-19T15:33:39+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"\/remote.php\/dav\/files\/Sven.Schneider\/Software\/putty-64bit-0.70-installer.msi","message":"renaming part file to final file failed"}

{"reqId":"zF7U19o8WQBhsm1AlVyV","level":3,"time":"2017-10-19T15:33:39+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"\/remote.php\/dav\/files\/Sven.Schneider\/Software\/putty-64bit-0.70-installer.msi","message":"run -> \"1\" renameok -> \"\" file_exists -> \"1\""}

{"reqId":"zF7U19o8WQBhsm1AlVyV","level":4,"time":"2017-10-19T15:33:39+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"\/remote.php\/dav\/files\/Sven.Schneider\/Software\/putty-64bit-0.70-installer.msi","message":"Exception: {\"Message\":\"HTTP\\\/1.1 500 Could not rename part file to final file\",\"Exception\":\"Sabre\\\\DAV\\\\Exception\",\"Code\":0,\"Trace\":\"#0 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(1129): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\File->put(Resource id #64)\\n#1 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(513): Sabre\\\\DAV\\\\Server->updateFile('files\\\/Sven.Schn...', Resource id #64, NULL)\\n#2 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpPut(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#3 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#4 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(479): Sabre\\\\Event\\\\EventEmitter->emit('method:PUT', Array)\\n#5 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#6 \\\/var\\\/www\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Server.php(234): Sabre\\\\DAV\\\\Server->exec()\\n#7 \\\/var\\\/www\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v2\\\/remote.php(31): OCA\\\\DAV\\\\Server->exec()\\n#8 \\\/var\\\/www\\\/owncloud\\\/remote.php(165): require_once('\\\/var\\\/www\\\/ownclo...')\\n#9 {main}\",\"File\":\"\\\/var\\\/www\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/File.php\",\"Line\":213,\"User\":\"Sven.Schneider\"}"}

jvillafanez · 2017-10-20T10:20:28Z

Ok, so the problem is in the moveFromStorage function that is returning false for some reason.

I'll need to know the implementation of the storage that is being used there. Add the following line around line 209:

\OCP\Util::writeLog('webdav', get_class($storage), \OCP\Util::ERROR);

We'll keep on debugging after knowing that info. As far as I know, there is no common implementation for that function (don't ask me why). I've checked that EE might use a wrapper in the workflow app which completely overwrite the method coming from the common storage, so right now I'm blinded.

Regarding the quota problem, I don't think that it's causing any problem. I've verified that OC 10.0.3 uploads file to the external storage without checking the quota, which is the expected behaviour, plus your logs doesn't have an "InsufficientQouta exception" or similar.

Did you check that there is enough space in the external storage for the file?

htwsaaraub · 2017-10-20T11:09:52Z

On the remote storage about 200GB of free space is available.
On that Volume no Quota Management is active.

Here are your requested debugging lines.

`{"reqId":"FK0R8SdRtts4T3oX0RlU","level":3,"time":"2017-10-20T11:00:31+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"/remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi","message":"OC\Files\Storage\Wrapper\Checksum"}

{"reqId":"eJTFnnmvyxSQbm1bg67X","level":3,"time":"2017-10-20T11:00:35+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"/remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi","message":"OC\Files\Storage\Wrapper\Checksum"}

{"reqId":"eJTFnnmvyxSQbm1bg67X","level":3,"time":"2017-10-20T11:00:35+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"/remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi","message":"renaming part file to final file failed"}

{"reqId":"eJTFnnmvyxSQbm1bg67X","level":3,"time":"2017-10-20T11:00:35+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"/remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi","message":"run -> "1" renameok -> "" file_exists -> "1""}
{"reqId":"eJTFnnmvyxSQbm1bg67X","level":4,"time":"2017-10-20T11:00:35+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"/remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi","message":"Exception: {"Message":"HTTP\/1.1 500 Could not rename part file to final file","Exception":"Sabre\\DAV\\Exception","Code":0,"Trace":"#0 \/var\/www\/owncloud\/lib\/composer\/sabre\/dav\/lib\/DAV\/Server.php(1129): OCA\\DAV\\Connector\\Sabre\\File->put(Resource id #64)\n#1 \/var\/www\/owncloud\/lib\/composer\/sabre\/dav\/lib\/DAV\/CorePlugin.php(513): Sabre\\DAV\\Server->updateFile('files\/Sven.Schn...', Resource id #64, NULL)\n#2 [internal function]: Sabre\\DAV\\CorePlugin->httpPut(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))\n#3 \/var\/www\/owncloud\/lib\/composer\/sabre\/event\/lib\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\n#4 \/var\/www\/owncloud\/lib\/composer\/sabre\/dav\/lib\/DAV\/Server.php(479): Sabre\\Event\\EventEmitter->emit('method:PUT', Array)\n#5 \/var\/www\/owncloud\/lib\/composer\/sabre\/dav\/lib\/DAV\/Server.php(254): Sabre\\DAV\\Server->invokeMethod(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))\n#6 \/var\/www\/owncloud\/apps\/dav\/lib\/Server.php(234): Sabre\\DAV\\Server->exec()\n#7 \/var\/www\/owncloud\/apps\/dav\/appinfo\/v2\/remote.php(31): OCA\\DAV\\Server->exec()\n#8 \/var\/www\/owncloud\/remote.php(165): require_once('\/var\/www\/ownclo...')\n#9 {main}","File":"\/var\/www\/owncloud\/apps\/dav\/lib\/Connector\/Sabre\/File.php","Line":214,"User":"Sven.Schneider"}"}

jvillafanez · 2017-10-20T13:45:04Z

Ok, the next debugging stop is https://github.com/owncloud/core/blob/v10.0.3/lib/private/Files/Storage/Wrapper/Wrapper.php#L565

Similar as above, I'm interested in the storage wrapped by the ChecksumWrapper:

\OCP\Util::writeLog('webdav', 'wrapper class: "' . get_class($this) . '"  --  wrapped class: "' . get_class($this->getWrapperStorage()) . '"  --  source: "' . get_class($sourceStorage) . '"', \OCP\Util::ERROR);

That should reveal enough info to know the actual method call that is failing.

htwsaaraub · 2017-10-20T13:55:02Z

Should it look like this? Or do you want the debuging line in the Query?

public function moveFromStorage(\OCP\Files\Storage $sourceStorage, $sourceInternalPath, $targetInternalPath) {

\OCP\Util::writeLog('webdav', 'wrapper class: "' . get_class($this) . '" -- wrapped class: "' . get_class($this->getWrapperStorage()) . '" -- source: "' . get_class($sourceStorage) . '"', \OCP\Util::ERROR);

if ($sourceStorage === $this) {
return $this->rename($sourceInternalPath, $targetInternalPath);
}

jvillafanez · 2017-10-23T06:48:53Z

Like you've written.

htwsaaraub · 2017-10-23T07:12:15Z

Here you are.

{"reqId":"28JtxM7ZYBbr5t3pxzLb","level":3,"time":"2017-10-23T07:04:29+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"/remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi","message":"wrapper class: "OC\Files\Storage\Wrapper\Checksum" -- wrapped class: "OC\Files\Storage\Wrapper\Encryption" -- source: "OC\Files\Storage\Wrapper\Checksum""}
{"reqId":"28JtxM7ZYBbr5t3pxzLb","level":3,"time":"2017-10-23T07:04:29+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"/remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi","message":"OC\Files\Storage\Wrapper\Checksum"}
{"reqId":"XspeU91T8OgpShwodsqw","level":3,"time":"2017-10-23T07:04:32+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"/remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi","message":"wrapper class: "OC\Files\Storage\Wrapper\Checksum" -- wrapped class: "OC\Files\Storage\Wrapper\Encryption" -- source: "OC\Files\Storage\Wrapper\Checksum""}
{"reqId":"XspeU91T8OgpShwodsqw","level":3,"time":"2017-10-23T07:04:32+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"/remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi","message":"OC\Files\Storage\Wrapper\Checksum"}
{"reqId":"XspeU91T8OgpShwodsqw","level":3,"time":"2017-10-23T07:04:32+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"/remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi","message":"renaming part file to final file failed"}
{"reqId":"XspeU91T8OgpShwodsqw","level":3,"time":"2017-10-23T07:04:32+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"/remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi","message":"run -> "1" renameok -> "" file_exists -> "1""}
{"reqId":"XspeU91T8OgpShwodsqw","level":4,"time":"2017-10-23T07:04:32+00:00","remoteAddr":"XXX.XXX.XXX.XXX","user":"Sven.Schneider","app":"webdav","method":"PUT","url":"/remote.php/dav/files/Sven.Schneider/Software/putty-64bit-0.70-installer.msi","message":"Exception: {"Message":"HTTP\/1.1 500 Could not rename part file to final file","Exception":"Sabre\\DAV\\Exception","Code":0,"Trace":"#0 \/var\/www\/owncloud\/lib\/composer\/sabre\/dav\/lib\/DAV\/Server.php(1129): OCA\\DAV\\Connector\\Sabre\\File->put(Resource id #64)\n#1 \/var\/www\/owncloud\/lib\/composer\/sabre\/dav\/lib\/DAV\/CorePlugin.php(513): Sabre\\DAV\\Server->updateFile('files\/Sven.Schn...', Resource id #64, NULL)\n#2 [internal function]: Sabre\\DAV\\CorePlugin->httpPut(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))\n#3 \/var\/www\/owncloud\/lib\/composer\/sabre\/event\/lib\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\n#4 \/var\/www\/owncloud\/lib\/composer\/sabre\/dav\/lib\/DAV\/Server.php(479): Sabre\\Event\\EventEmitter->emit('method:PUT', Array)\n#5 \/var\/www\/owncloud\/lib\/composer\/sabre\/dav\/lib\/DAV\/Server.php(254): Sabre\\DAV\\Server->invokeMethod(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))\n#6 \/var\/www\/owncloud\/apps\/dav\/lib\/Server.php(234): Sabre\\DAV\\Server->exec()\n#7 \/var\/www\/owncloud\/apps\/dav\/appinfo\/v2\/remote.php(31): OCA\\DAV\\Server->exec()\n#8 \/var\/www\/owncloud\/remote.php(165): require_once('\/var\/www\/ownclo...')\n#9 {main}","File":"\/var\/www\/owncloud\/apps\/dav\/lib\/Connector\/Sabre\/File.php","Line":214,"User":"Sven.Schneider"}"}

Seams like the Wrapper Encryption causing this Problem. But in my Owncloud Instance the Encryption Module is not enabled.

Enabled:

activity: 2.3.6

announcementcenter: 1.2.0

configreport: 0.1.1

dav: 0.3.0

external: 1.2

federatedfilesharing: 0.3.1

federation: 0.1.0

files: 1.5.1

files_clipboard: 0.6.2

files_external: 0.7.1

files_external_ftp: 0.2.0

files_pdfviewer: 0.8.2

files_texteditor: 2.2.1

firstrunwizard: 1.1

impersonate: 0.1.0

market: 0.2.2

notifications: 0.3.1

provisioning_api: 0.5.0

templateeditor: 0.1

updatenotification: 0.2.1

user_ldap: 0.9.1

Disabled:

comments

encryption

files_antivirus

files_sharing

files_trashbin

files_versions

files_videoplayer

systemtags

theme-example

user_external

jvillafanez · 2017-10-23T11:25:05Z

Let's try another approach: add the following option in your config.php and set the log level to debug (the place doesn't matter)

  'passwordsalt' => 'blablabla',
  'secret' => 'blablabla',
  'trusted_domains' =>
  array (
    0 => 'server',
  ),
  'datadirectory' => '/opt/owncloud/data',
  'wnd.logging.enable' => true,    <------

Note that the log output will be very verbose so either remove the option or set it as false afterwards.

I expect some entries with something like:

enter: rename ....
rename swallowing ......  message ... trace ....
leave: rename, return false

Hopefully we can get a stacktrace of the error that's happening in the SMB code (if the execution really go through it). It should be more or less clear what is happening inside the rename.

htwsaaraub · 2017-10-23T14:04:56Z

Icewind\SMB\Exception\NotFoundException - code: 2 message: Invalid request for smb

jvillafanez · 2017-10-24T12:08:44Z

Icewind\SMB\Exception\NotFoundException - code: 2 message: Invalid request for smb

That's kind of expected because we need to check if the file exists in the SMB server or not, so that exception is under control. The problem is the other one happening during the rename.

rename swallowing Icewind\\SMB\\Exception\\Exception - code: 22 message: Unknown error (22) for smb:\/\/XXXXX\/Folder\/putty-64bit-0.70-installer.msi

This is quite bad news because I don't know how to reproduce the error nor what could be the cause of it.

I'm not sure if you've checked already:

Does the file uploads through the ownCloud's web UI? windows might be doing some strange things that could affect the outcome of the upload.
Does the file uploads through other SMB clients, such as "cadaver" or "smbclient"?

Maybe a wireshark trace could show some additional information.

htwsaaraub · 2017-10-26T07:24:54Z

I have some news.

The Uploads through the web UI all work like a charm.
As you suggested I tested some other webdav clients.
I had the same results (renaming part file to final file failed) with

WindowsExplorer WebDav,
NetDav3 (which also mounts a WebDav Connection in Windows Explorer)
MacOS 10.13 WebDav Connection via Finder. MacOS doesn't throw a error message. Instead leaving a 0 byte File in the WebDav File System.

For Windows I also tested CarotDAV. This Client doesn't integrate in Windows, instead navigating the WebDAV file System in the Application.
CarotDAV uploads any File correct. There are no errors in the owncloud log.
Perhaps this client just ignores the Quota limit, because all other clients have the Same results.

jvillafanez · 2017-10-26T08:49:07Z

@htwsaaraub could you try with the old webdav endpoint? It should be something like https://owncloud.local/remote.php/webdav/ At least this will shrink the scope.
If it works then there is definitely a problem with the new webdav endpoint that we'll need to fix.

Quota limits are handled in the server, so I doubt the CarotDAV has something to do with that. It might be that CarotDAV uploads the whole file at once, but the rest tries to upload the file by chunks (or maybe it's the other way around).
Web uploads are still using the old webdav endpoint.

htwsaaraub · 2017-10-26T10:06:17Z

@jvillafanez Nope, no change. Same results with the old and new endpoint.
NetDrive3 displays the correct user Quota for both of the Endpoints, but the Quota is always used for External SMB Shares.

jvillafanez · 2017-10-26T11:46:20Z

I'm out of ideas at the moment 😞
I'll try to setup something similar in order to properly debug this, but I don't expect to have the environment ready until next week, so if there is no activity ping me in 2 weeks for status.

If you have any other ideas or more information, feel free to drop by this ticket.

Meanwhile, you might want to try the ownCloud's desktop client, which I expect to work properly and should provide similar features.

jvillafanez · 2017-11-15T07:44:56Z

@htwsaaraub could you test with OC 10.0.4RC1? We've merged something that might solve your issue.

htwsaaraub · 2017-12-15T11:35:51Z

@jvillafanez Today I tested the OC 10.0.4 final release.

I can confirm, webdav is now working as expected. Files on external shares are no longer limited by the quota size.

For Connections with Windows integrated WebDav client you first have to start the WebClient Service, which isn't set to start Automatic with windows.
Also I had to set the Connect using different credentials checkbox to connect successful.

I found a Micorosoft Support Document for Windows 7, which is sill valid under Windows 10.
https://support.microsoft.com/en-us/help/2560598/-the-folder-you-entered-does-not-appear-to-be-valid--please-choose-ano

PVince81 · 2017-12-15T12:14:10Z

Glad to hear!

Case closed then ?

htwsaaraub · 2017-12-15T13:44:19Z

Case closed.
Thanks for your support. 👍

lock · 2019-07-30T20:00:27Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

htwsaaraub mentioned this issue Sep 27, 2017

WebDav: User Quota on external Shares #28305

Closed

PVince81 added the bug-analysis label Oct 9, 2017

PVince81 self-assigned this Oct 9, 2017

PVince81 added this to the development milestone Oct 9, 2017

PVince81 added the regression label Oct 9, 2017

PVince81 mentioned this issue Oct 10, 2017

Add test with external storage and quota #29193

Merged

9 tasks

PVince81 mentioned this issue Oct 10, 2017

Federation: Upload reports insufficient storage but we are far from any limit #29169

Closed

PVince81 assigned jvillafanez and unassigned PVince81 Oct 16, 2017

PVince81 modified the milestones: development, triage Nov 3, 2017

htwsaaraub closed this as completed Dec 15, 2017

felixboehm removed this from the triage milestone Apr 10, 2018

lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Webdav: Could not rename part file to final file due to Quota limit #29103

Webdav: Could not rename part file to final file due to Quota limit #29103

htwsaaraub commented Sep 27, 2017

PVince81 commented Oct 9, 2017

PVince81 commented Oct 10, 2017

htwsaaraub commented Oct 11, 2017

PVince81 commented Oct 12, 2017

PVince81 commented Oct 12, 2017

htwsaaraub commented Oct 12, 2017

PVince81 commented Oct 13, 2017

htwsaaraub commented Oct 13, 2017

PVince81 commented Oct 13, 2017

jvillafanez commented Oct 16, 2017

htwsaaraub commented Oct 19, 2017

jvillafanez commented Oct 20, 2017

htwsaaraub commented Oct 20, 2017

jvillafanez commented Oct 20, 2017

htwsaaraub commented Oct 20, 2017

jvillafanez commented Oct 23, 2017

htwsaaraub commented Oct 23, 2017 •

edited

jvillafanez commented Oct 23, 2017

htwsaaraub commented Oct 23, 2017

jvillafanez commented Oct 24, 2017

htwsaaraub commented Oct 26, 2017 •

edited

jvillafanez commented Oct 26, 2017

htwsaaraub commented Oct 26, 2017

jvillafanez commented Oct 26, 2017

jvillafanez commented Nov 15, 2017 •

edited

htwsaaraub commented Dec 15, 2017

PVince81 commented Dec 15, 2017

htwsaaraub commented Dec 15, 2017

lock bot commented Jul 30, 2019

Webdav: Could not rename part file to final file due to Quota limit #29103

Webdav: Could not rename part file to final file due to Quota limit #29103

Comments

htwsaaraub commented Sep 27, 2017

Steps to reproduce

Expected behaviour

Actual behaviour

Server configuration

Client configuration

Logs

Web server error log

ownCloud log (data/owncloud.log)

PVince81 commented Oct 9, 2017

PVince81 commented Oct 10, 2017

htwsaaraub commented Oct 11, 2017

PVince81 commented Oct 12, 2017

PVince81 commented Oct 12, 2017

htwsaaraub commented Oct 12, 2017

PVince81 commented Oct 13, 2017

htwsaaraub commented Oct 13, 2017

PVince81 commented Oct 13, 2017

jvillafanez commented Oct 16, 2017

htwsaaraub commented Oct 19, 2017

jvillafanez commented Oct 20, 2017

htwsaaraub commented Oct 20, 2017

jvillafanez commented Oct 20, 2017

htwsaaraub commented Oct 20, 2017

jvillafanez commented Oct 23, 2017

htwsaaraub commented Oct 23, 2017 • edited

jvillafanez commented Oct 23, 2017

htwsaaraub commented Oct 23, 2017

jvillafanez commented Oct 24, 2017

htwsaaraub commented Oct 26, 2017 • edited

jvillafanez commented Oct 26, 2017

htwsaaraub commented Oct 26, 2017

jvillafanez commented Oct 26, 2017

jvillafanez commented Nov 15, 2017 • edited

htwsaaraub commented Dec 15, 2017

PVince81 commented Dec 15, 2017

htwsaaraub commented Dec 15, 2017

lock bot commented Jul 30, 2019

htwsaaraub commented Oct 23, 2017 •

edited

htwsaaraub commented Oct 26, 2017 •

edited

jvillafanez commented Nov 15, 2017 •

edited